Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
✏ Fix typos intests/test_schema_extra_examples.py#5126
✏ Fix typos intests/test_schema_extra_examples.py#5126tiangolo merged 2 commits intofastapi:masterfrom
tests/test_schema_extra_examples.py#5126Conversation
While doing a typing test on speedtyper.dev, I got a snippet that had a typo, so decided to drop by and fix it ;)
📝 Docs preview for commit89fc150 at:https://62cd6d8f1347e4132102d679--fastapi.netlify.app |
odiseo0 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tests are not passing because inopenapi_schema still has some of that 'Qeury' mistake, you have to change them for the tests
codecovbot commentedJul 15, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #5126 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 532 532 Lines 13672 13684 +12 =========================================+ Hits 13672 13684 +12
Continue to review full report at Codecov.
|
supraaxdd commentedJul 15, 2022
Okay everything is good to go, thanks for letting me know about the other typos I overlooked! |
📝 Docs preview for commite189fea at:https://62d1bb4d43a452635297363b--fastapi.netlify.app |
odiseo0 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
tiangolo commentedAug 26, 2022
Ha! That's fun, thank you@supraaxdd! 🍰 And thanks everyone for the interactions! |
While doing a typing test on speedtyper.dev, I got a snippet that had a typo, so decided to drop by and fix it ;)