Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
♻️ Move fromOptional[X] toUnion[X, None] for internal utils#5124
Merged
♻️ Move fromOptional[X] toUnion[X, None] for internal utils#5124
Optional[X] toUnion[X, None] for internal utils#5124Conversation
codecovbot commentedJul 11, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #5124 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 532 532 Lines 13672 13672 ========================================= Hits 13672 13672 Continue to review full report at Codecov.
|
Contributor
josegonzalez commentedJul 14, 2022
I'm curious as to why this change was implemented. It doesn't break anything for me, I'm just wondering if Union should be preferred to Optional in my own code :D |
zoliknemet commentedJul 15, 2022
Simple answer: tiangolo prefers Union |
m9810223 commentedJul 15, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull requestAug 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Move from
Optional[X]toUnion[X, None]for internal utils