Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

🌐 Add Chinese translation fordocs/zh/docs/tutorial/dependencies/classes-as-dependencies.md#4971

Merged
tiangolo merged 7 commits intofastapi:masterfrom
Zssaer:zssaer-translation-classes-as-dependencies
Oct 31, 2022
Merged

🌐 Add Chinese translation fordocs/zh/docs/tutorial/dependencies/classes-as-dependencies.md#4971
tiangolo merged 7 commits intofastapi:masterfrom
Zssaer:zssaer-translation-classes-as-dependencies

Conversation

@Zssaer
Copy link
Contributor

Translates docs/zh/docs/tutorial/dependencies/classes-as-dependencies.md and add deploy menu in Chinese.
related:#1228

tiangolo reacted with rocket emoji
@codecov
Copy link

codecovbot commentedMay 31, 2022•
edited
Loading

Codecov Report

Base:100.00% // Head:100.00% // No change to project coverage 👍

Coverage data is based on head(9e7ec21) compared to base(7ff6246).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@##            master     #4971   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          540       540             Lines        13946     13946           =========================================  Hits         13946     13946

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit37e04df at:https://6295d912b2eeb81e2e62dd3f--fastapi.netlify.app

@tiangolotiangolo changed the title🌐 Add Chineses translation for docs/zh/docs/tutorial/dependencies/classes-as-dependencies.md🌐 Add Chinese translation fordocs/zh/docs/tutorial/dependencies/classes-as-dependencies.mdJul 14, 2022
@tiangolotiangolo added lang-allTranslations lang-zhChinese translations awaiting-review labelsJul 14, 2022
@github-actionsgithub-actionsbot mentioned this pull requestJul 14, 2022
Copy link
Contributor

@JedoreJedore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I reviewed your changes and made some optimization. Can I push them ?

@Zssaer
Copy link
ContributorAuthor

I reviewed your changes and made some optimization. Can I push them ?

Sure

@Jedore
Copy link
Contributor

Jedore commentedOct 14, 2022•
edited
Loading

I reviewed your changes and made some optimization. Can I push them ?

Sure

But it seems I have no permission:

$ git push zssaer head:zssaer-translation-classes-as-dependenciesERROR: Permission to Zssaer/fastapi.git denied to Jedore.fatal: Could not read from remote repository.Please make sure you have the correct access rightsand the repository exists.

Am I something wrong ? Or how can I push changes to this PR? Or can I only comment some lines in per review. Because I reviewed and changed much lines. Thanks.@tiangolo@Zssaer

@ASpathfinder
Copy link
Contributor

ASpathfinder commentedOct 14, 2022•
edited
Loading

I reviewed your changes and made some optimization. Can I push them ?

Sure

But it seems I have no permission:

$ git push zssaer head:zssaer-translation-classes-as-dependenciesERROR: Permission to Zssaer/fastapi.git denied to Jedore.fatal: Could not read from remote repository.Please make sure you have the correct access rightsand the repository exists.

Am I something wrong ? Or how can I push changes to this PR? Or can I only comment some lines in per review. Because I reviewed and changed much lines. Thanks.@tiangolo@Zssaer

Looks like you don't have permission to do that.See

@Zssaer
Copy link
ContributorAuthor

I reviewed your changes and made some optimization. Can I push them ?

Sure

But it seems I have no permission:

$ git push zssaer head:zssaer-translation-classes-as-dependenciesERROR: Permission to Zssaer/fastapi.git denied to Jedore.fatal: Could not read from remote repository.Please make sure you have the correct access rightsand the repository exists.

Am I something wrong ? Or how can I push changes to this PR? Or can I only comment some lines in per review. Because I reviewed and changed much lines. Thanks.@tiangolo@Zssaer

Only the upstream repository maintainers can direct change it.
Try to create pull request.

@Jedore
Copy link
Contributor

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

@Zssaer
Copy link
ContributorAuthor

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

Jedore，你目前还是否有意愿进行提交一些修改？如果你嫌一段一段Request changes麻烦的话，我的意思是 你可以将这个PR的Branch给Fork下来，然后再进行PR给这个Branch。

@Jedore
Copy link
Contributor

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

Jedore，你目前还是否有意愿进行提交一些修改？如果你嫌一段一段Request changes麻烦的话，我的意思是 你可以将这个PR的Branch给Fork下来，然后再进行PR给这个Branch。

之前没有对你的branch推送的权限，所以我已经将我所有的修改建议在上面以review的形式提交了，需要你去按需选择接受或拒绝就可以了。目前我没有其他的修改建议了，所以也不用再提PR给你的branch了 😂

@Zssaer
Copy link
ContributorAuthor

@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them.

Jedore，你目前还是否有意愿进行提交一些修改？如果你嫌一段一段Request changes麻烦的话，我的意思是 你可以将这个PR的Branch给Fork下来，然后再进行PR给这个Branch。

之前没有对你的branch推送的权限，所以我已经将我所有的修改建议在上面以review的形式提交了，需要你去按需选择接受或拒绝就可以了。目前我没有其他的修改建议了，所以也不用再提PR给你的branch了 😂

可是我并没有收到你的相关review的提交

@Jedore
Copy link
Contributor

@Zssaer 现在可以看到了吗？第一次 review， 打开review， 忘记提交review了

Zssaerand others added3 commitsOctober 18, 2022 23:20
0Co-authored-by: Jeodre <jedore_fight@189.cn>
All suggestions to oneCo-authored-by: Jeodre <jedore_fight@189.cn>
@github-actions
Copy link
Contributor

📝 Docs preview for commita77ebd0 at:https://63600c790ccda20c0446c3b3--fastapi.netlify.app

@tiangolotiangolo merged commitfcab59b intofastapi:masterOct 31, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@JedoreJedoreJedore approved these changes

@132055591113205559111320555911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-zhChinese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zssaer@Jedore@ASpathfinder@1320555911@tiangolo
[8]ページ先頭
©2009-2026 Movatter.jp