Codecov Report

Patch coverage:100.00% and no project coverage change.

Comparison is base(cf73051) 100.00% compared to head(63efdc0) 100.00%.

❗ Current head63efdc0 differs from pull request most recent headc3bc61b. Consider uploading reports for the commitc3bc61b to get more accurate results

@@            Coverage Diff             @@##            master     #4958    +/-   ##==========================================  Coverage   100.00%   100.00%            ==========================================  Files          540       532     -8       Lines        13969     13672   -297     ==========================================- Hits         13969     13672   -297

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment?Let us know in this issue.

📝 Docs preview for commit63efdc0 at:https://628faf69384877273be629ca--fastapi.netlify.app

@Ryandaydev it'd be great if you can list out the errors. I see the GitHub checks have passed for this PR.

When I use gh checkout 4958, it looks at the ryanrussell/master branch. In that branch, it looks like the test-cov-html.sh file is an old version containing an argument that isn't in the main branch version.

So I can't run the test coverage script to get a clean test run.

Here is the error:
pytest: error: unrecognized arguments: --cov=fastapi --cov=tests --cov=docs_src --cov-report=term-missing:skip-covered --cov-report=xml --cov-report=html

@Ryandaydev I checked from local, it works fine.

1346 passed in 21.79s

Ensure you have installed all the dependencies needed.

pip install -e ."[dev,doc,test]" --upgrade

Then run:

coverage run -m pytest tests

Thanks, the pip command resolved my issue. No objections now -- I'll mark it as approve.

Great, thanks@ryanrussell! 🔍 🤓

And thanks for the reviews and comments everyone! ☕