Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
📝 Add documentation for redefined path operations#4864
Merged
tiangolo merged 2 commits intofastapi:masterfromMay 12, 2022
Merged
📝 Add documentation for redefined path operations#4864tiangolo merged 2 commits intofastapi:masterfrom
tiangolo merged 2 commits intofastapi:masterfrom
Conversation
codecovbot commentedMay 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #4864 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 531 531 Lines 13627 13629 +2 =========================================+ Hits 13627 13629 +2
Continue to review full report at Codecov.
|
Contributor
📝 Docs preview for commit2c441af at:https://6272c2ad3e78ba024bb33491--fastapi.netlify.app |
zangell44 approved these changesMay 11, 2022
Contributor
📝 Docs preview for commitbac9cae at:https://627d32652b19d50a163a9339--fastapi.netlify.app |
Member
tiangolo commentedMay 12, 2022
Awesome, thanks@madkinsz! 📝 |
ContributorAuthor
zanieb commentedMay 12, 2022
You're welcome! I appreciate your improvements :) |
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull requestAug 20, 2022
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
We define a FastAPI application that needs to have some selective routes overridden, but redefining a route does not change its behavior. This makes some sense once you readhttps://www.starlette.io/routing/#route-priority but was not entirely clear inhttps://fastapi.tiangolo.com/tutorial/path-params/#order-matters.
This pull request adds a brief blurb to the "Order matters" section about redefinition of path operations. Preview athttps://6272c2ad3e78ba024bb33491--fastapi.netlify.app/tutorial/path-params/#order-matters
I'd also like to open a separate PR to link to the Starlette routing documentation and describe why adding routers with colliding path operations always results in the first router's implementation being used. Let me know if there's a good place for that.