Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
✏ Reword to improve legibility of docs aboutTestClient#4389
Merged
tiangolo merged 2 commits intofastapi:masterfromMay 10, 2022
Merged
✏ Reword to improve legibility of docs aboutTestClient#4389tiangolo merged 2 commits intofastapi:masterfrom
TestClient#4389tiangolo merged 2 commits intofastapi:masterfrom
Conversation
I find the ordering of this sentence hard to parse -- I'm no scholarof english grammar, but as a native speaker the current word orderingfeels not quite right.
joakimnordling approved these changesJan 9, 2022
Contributor
joakimnordling left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
TestClientMember
tiangolo commentedMay 10, 2022
Great, thanks@rgilton! 🔍 |
codecovbot commentedMay 10, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #4389 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 531 531 Lines 13629 13629 ========================================= Hits 13629 13629 Continue to review full report at Codecov.
|
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull requestAug 20, 2022
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find the ordering of this sentence hard to parse -- I'm no scholar
of english grammar, but as a native speaker the current word ordering
feels not quite right.