Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Additional responses can be status groups or "default"#435
Additional responses can be status groups or "default"#435tiangolo merged 3 commits intofastapi:masterfromdivums:status_codes
Conversation
codecovbot commentedAug 13, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #435 +/- ##===================================== Coverage 100% 100% ===================================== Files 240 244 +4 Lines 5626 5707 +81 =====================================+ Hits 5626 5707 +81
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@## master #435 +/- ##==========================================- Coverage 100% 99.98% -0.02%========================================== Files 240 240 Lines 5626 5632 +6 ==========================================+ Hits 5626 5631 +5- Misses 0 1 +1
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
tiangolo commentedAug 30, 2019
Awesome, thanks@divums ! Good job! 🚀 🍰 I updated it a bit, to use uppercase instead of lowercase, to conform with the spec:https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#patterned-fields-1 And I augmented the tests to include some more of these cases. And thanks a lot@dmontagu for the code review and help here! 👏 💪 🍰 |
tiangolo commentedAug 30, 2019
I realized I introduced a bug making it But I just fixed it in#489 🐛 I also added extra tests there to include |
Uh oh!
There was an error while loading.Please reload this page.
Catching exception when generating OpenAPI specification. Added status groups and "default" as possible key for the additional responses.
If merged, this issuefixes#428