Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

🌐 Add Korean translation fordocs/ko/docs/deployment/versions.md#4121

Merged
tiangolo merged 10 commits intofastapi:masterfrom
DevDae:docs-deployment-versions
Dec 8, 2021
Merged

🌐 Add Korean translation fordocs/ko/docs/deployment/versions.md#4121
tiangolo merged 10 commits intofastapi:masterfrom
DevDae:docs-deployment-versions

Conversation

@DevDae
Copy link
Contributor

Copy link
Contributor

@0417taehyun0417taehyun left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Feel free to check my reviews!

It's honor to check yours 🚀

PS. It would be better to add a file path inmkdocs.yml, which indocs/ko.

Copy link
Contributor

@0417taehyun0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I add the reviews because of word,애플리케이션.

If you check파이썬 한국어 번역 and search word,application, it is translated as응용 프로그램 and because we follows the rules of that guide (check of it on#2017 ).

Big appreciate your works 🚀

DevDaeand others added8 commitsNovember 3, 2021 15:18
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@0417taehyun
Copy link
Contributor

LGTM 🚀

PS.
If you help review others, it will be help of Korean seeing docs easily and better 🥳
There are several pull requests waiting for reviews (check#2017 ).

@DevDae
Copy link
ContributorAuthor

LGTM 🚀

PS. If you help review others, it will be help of Korean seeing docs easily and better 🥳 There are several pull requests waiting for reviews (check#2017 ).

Sure, i will check other reviews for flourishing Korean translations! thanks! 😆

0417taehyun reacted with thumbs up emoji0417taehyun reacted with heart emoji0417taehyun and tiangolo reacted with rocket emoji

Copy link
Contributor

@0417taehyun0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@tiangolo

This is PERFECT 🚀

tiangolo reacted with heart emoji
@tiangolotiangolo added approved-2 lang-allTranslations lang-koKorean translations labelsDec 8, 2021
@tiangolo
Copy link
Member

Amazing, thanks for your contribution@DevDae! 🍪

And thanks for the reviews@kty4119 and and@0417taehyun! 👏 🍰

DevDae reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@kty4119kty4119kty4119 approved these changes

@0417taehyun0417taehyun0417taehyun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-koKorean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DevDae@0417taehyun@tiangolo@kty4119
[8]ページ先頭
©2009-2026 Movatter.jp