Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

📝 Add external link to blog post about Kafka, FastAPI, and Ably#4044

Merged
tiangolo merged 2 commits intofastapi:masterfrom
Ugbot:patch-1
May 10, 2022
Merged

📝 Add external link to blog post about Kafka, FastAPI, and Ably#4044
tiangolo merged 2 commits intofastapi:masterfrom
Ugbot:patch-1

Conversation

@Ugbot
Copy link
Contributor

added my blog to the list of links, its about using FastAPI with Kafka and ably

added my blog to the list of links, its about using FastAPI with Kafka and ably
Copy link
Contributor

@ArcLightSlavikArcLightSlavik left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Change name of PR to: Added article about ticket booking with FastAPI and Kafka
Comments below are nitpicks, seems like a good article.

class Conference(BaseModel):    eventId: str    eventCapacity: int    eventDate: int    bookingStart: int    bookingEnd: int    timestamp: int    pass

remove the 'pass'

@app.post('/inbound-conferences')async def conference_creation(data: Conference, request: Request):    try:        conference_producer.produce(conference_topic, None, data.dict())        conference_producer.poll(0)        conference_producer.flush()        print(data.dict())    except Exception as e:        print(e)        return 400   return 200

request isn't being used

@tiangolotiangolo changed the titleadded my blog to the list of external links📝 Add external link to blog post about Kafka, FastAPI, and AblyMay 10, 2022
@tiangolotiangoloenabled auto-merge (squash)May 10, 2022 01:19
@tiangolo
Copy link
Member

Cool, thanks!

@codecov
Copy link

codecovbot commentedMay 10, 2022
edited
Loading

Codecov Report

Merging#4044 (6f323d7) intomaster (fa1ffa5) willnot change coverage.
The diff coverage isn/a.

@@            Coverage Diff            @@##            master     #4044   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          531       531             Lines        13629     13629           =========================================  Hits         13629     13629

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefa1ffa5...6f323d7. Read thecomment docs.

@tiangolotiangolo merged commit8f90e51 intofastapi:masterMay 10, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull requestAug 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ArcLightSlavikArcLightSlavikArcLightSlavik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ugbot@tiangolo@ArcLightSlavik

[8]ページ先頭

©2009-2026 Movatter.jp