Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

💚 Fix badges in README and main page#3979

Merged
tiangolo merged 8 commits intofastapi:masterfrom
ghandic:fix/readme-badge
Oct 3, 2021
Merged

💚 Fix badges in README and main page#3979
tiangolo merged 8 commits intofastapi:masterfrom
ghandic:fix/readme-badge

Conversation

@ghandic
Copy link
Contributor

Fixing workflow badge to point to the master branch and not forks with PR. Looking into how to do the same for codecov

@tiangolotiangolo changed the titleFix/readme badge💚 Fix badges in README and main pageOct 3, 2021
@github-actions
Copy link
Contributor

📝 Docs preview for commit6a7b9f4 at:https://6159f015663db637a7488e2c--fastapi.netlify.app

@tiangolo
Copy link
Member

tiangolo commentedOct 3, 2021
edited
Loading

Awesome, thank you@ghandic! 🚀

I just updated the main page as well, the README is generated from it, so now tests should pass. Thanks for your contribution! 🍰

I also updated the Coverage upload, it's needed in PRs too to be able to measure their coverage changes.

@github-actions
Copy link
Contributor

📝 Docs preview for commit7e3ccf1 at:https://6159f1281218000f3b70ed2c--fastapi.netlify.app

@codecov
Copy link

codecovbot commentedOct 3, 2021
edited
Loading

Codecov Report

Merging#3979 (c8008e6) intomaster (1b6350a) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #3979   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          410       410             Lines        10281     10281           =========================================  Hits         10281     10281

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1b6350a...c8008e6. Read thecomment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commitc8008e6 at:https://6159f203bb69fce44748d893--fastapi.netlify.app

@tiangolotiangolo merged commit099c478 intofastapi:masterOct 3, 2021
@ghandic
Copy link
ContributorAuthor

You'll be measuring the PR coverage and displaying that on the main page though. I did have a look to see if there was some filtering that could be done for that badge but couldn't see anything at a first pass.

I'll continue to look 👍🏻

tiangolo reacted with heart emoji

@ghandic
Copy link
ContributorAuthor

We could add flags conditional of whether it is a PR or a push and then filter by that flag for the badge. I'll make another PR today to fix, that way you'll keep the codecov run for PR to check but also have the coverage % accurate on the readme

https://community.codecov.com/t/badges-for-flags/270/5

tiangolo reacted with heart emoji

@ghandic
Copy link
ContributorAuthor

@tiangolo see PR -#3982

tiangolo reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ghandic@tiangolo

[8]ページ先頭

©2009-2026 Movatter.jp