fastapi/fastapiPublic

NotificationsYou must be signed in to change notification settings
Fork8.7k
Star95.4k

🌐 Add Korean translation for`docs/ko/docs/tutorial/path-operation-configuration.md`#3639

Merged

alejsdev merged 9 commits intofastapi:masterfrom

jungsu-kwon:master

Jan 22, 2024

Merged

🌐 Add Korean translation for`docs/ko/docs/tutorial/path-operation-configuration.md`#3639
alejsdev merged 9 commits intofastapi:masterfrom
jungsu-kwon:master

Conversation

Copy link

Contributor

jungsu-kwon commentedJul 31, 2021

hello I have added korean translation for

path-operation-configuration.md

thank you for reviews in prior

related#2017

added korean translation for path-operation-configuration.md

979ab7f

tiangolo changed the title~~🌐 Add Korean translation for Tutorial - Path Operation Configuration.md~~🌐 Add Korean translation fordocs/tutorial/path-operation-configuration.md

Aug 18, 2021

tiangolo added awaiting-review lang-all

Translations

lang-koKorean translations labels

Aug 18, 2021

github-actionsbot mentioned this pull request

Aug 18, 2021

Korean translations#2017

Closed

hard-coders reviewed

Sep 5, 2021

View reviewed changes

Copy link

Contributor

hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Welcome aboard and nice work🎉 Please check my reviews.

docs/ko/docs/tutorial/path-operation-configuration.md Outdated


		각 상태 코드들은 응답에 사용되며, OpenAPI 스키마에 추가됩니다.

		!!! note "기술적 디테일"

Copy link

Contributor

hard-codersSep 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	!!! note "기술적 디테일"
	!!! note "기술 세부사항"

It is better to use the same term.

docs/ko/docs/tutorial/path-operation-configuration.md Outdated


		## Tags

		경로 동작에 태그를 달수도 있습니다, `tags` 매개변수를 `str`으로 이루어진 `list`의 형태로 전달하시면 됩니다 (보통은 한개의 `str`으로 이루어져 있습니다.)

Copy link

Contributor

hard-codersSep 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	경로 동작에 태그를달수도있습니다,`tags` 매개변수를`str`으로 이루어진`list`의 형태로 전달하시면 됩니다 (보통은한개의`str`으로 이루어져 있습니다.)
	경로 동작에 태그를달 수있습니다,`tags` 매개변수를`str`으로 이루어진`list`의 형태로 전달하시면 됩니다 (보통은한 개의`str`으로 이루어져 있습니다):

docs/ko/docs/tutorial/path-operation-configuration.md Outdated

Comment on lines 63 to 64

		`response_description` 매개변수로 응답 기술을 명시할수 있습니다.
		You can specify the response description with the parameter `response_description`:

Copy link

Contributor

hard-codersSep 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	`response_description` 매개변수로 응답 기술을 명시할수 있습니다.
	You can specify the response description with the parameter`response_description`:
	`response_description` 매개변수로 응답 기술을 명시할 수 있습니다:

docs/ko/docs/tutorial/path-operation-configuration.md Outdated


		## 독스트링으로 만든 기술

		기술이 보통 길고 여러줄에 걸쳐있기 때문에, 경로 동작 기술을 함수 <abbr title="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열"> 독스트링</abbr> 에 선언할수 있습니다, 이를 FastAPI가 독스트링으로부터 읽습니다.

Copy link

Contributor

hard-codersSep 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	기술이 보통길고 여러줄에걸쳐있기 때문에,경로 동작 기술을 함수 <abbrtitle="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열"> 독스트링</abbr> 에선언할수 있습니다, 이를FastAPI가 독스트링으로부터 읽습니다.
	설명은 보통길어지고 여러 줄에걸쳐있기 때문에,경로 동작 기술을 함수 <abbrtitle="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열�"> 독스트링</abbr> 에선언할 수 있습니다, 이를FastAPI가 독스트링으로부터 읽습니다.

I think설명 is better than기술 because the latter one confuses "description" with "technique"

reflected suggestions from code-review

726bdb2

0417taehyun suggested changes

Nov 5, 2021

View reviewed changes

Copy link

Contributor

0417taehyun left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Big appreciate of your works and great honor to check it 🚀

Please feel free to check my reviews and update (fetch) the file to latest version.

Also, please add a file path tomkdocs.yml !

docs/ko/docs/tutorial/path-operation-configuration.md OutdatedShow resolvedHide resolved

jungsu-kwonand others added4 commits

November 21, 2021 10:26

Apply suggestions from code review

4b23eb2

applied suggestion from@0417taehyunthank you for correctionCo-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>

Merge branch 'master' ofhttps://github.com/tiangolo/fastapi

a1ec98d

pulled latest updates in fastapi

removed trailing whitespaces

80139f8

updated mkdocs.yml to add tutorial/path-operation-configuration.md

faaa11a

Copy link

ContributorAuthor

jungsu-kwon commentedNov 21, 2021

@hard-coders @0417taehyun added revision to pr

thank you for all the suggestions

could you please review again to finalize pr?

hard-coders reviewed

Nov 21, 2021

View reviewed changes

Copy link

Contributor

hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your effort! I reviewd some typos

docs/ko/docs/tutorial/path-operation-configuration.md OutdatedShow resolvedHide resolved

Apply suggestions from code review

68b164b

applied review regarding style and typosCo-authored-by: Spike <rurouni24@gmail.com>

hard-coders approved these changes

Dec 2, 2021

View reviewed changes

Copy link

Contributor

hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

Copy link

ContributorAuthor

jungsu-kwon commentedDec 6, 2021

@hard-coders Do I need to do anything additional to finalize the merge?

Copy link

Contributor

hard-coders commentedDec 6, 2021

@hard-coders Do I need to do anything additional to finalize the merge?

No, you don't need to. Please wait for the other reviewer and maintainer's approval.

Copy link

ContributorAuthor

jungsu-kwon commentedDec 6, 2021

@hard-coders thx

Merge branch 'master' into master

247d4da

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request

Aug 6, 2022

translated byfastapi#3639

49820c3

Merge branch 'master' into master

d63019c

tiangolo changed the title~~🌐 Add Korean translation fordocs/tutorial/path-operation-configuration.md~~🌐 Add Korean translation fordocs/ko/docs/tutorial/path-operation-configuration.md

Jun 26, 2023

tiangolo added awaiting-review and removed awaiting-review labels

Jun 26, 2023