Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

✏️ Add a missing comma in the security tutorial#3564

Merged
tiangolo merged 5 commits intofastapi:masterfrom
jalvaradosegura:add-missing-comma-in-tutorial
Oct 7, 2021
Merged

✏️ Add a missing comma in the security tutorial#3564
tiangolo merged 5 commits intofastapi:masterfrom
jalvaradosegura:add-missing-comma-in-tutorial

Conversation

@jalvaradosegura
Copy link
Contributor

There is a missing comma in the list of things that the paragraph is mentioning

@tiangolotiangoloenabled auto-merge (squash)July 21, 2021 12:49
@tiangolo
Copy link
Member

Good catch, thank you@jalvaradosegura! 🙇 🔍

jalvaradosegura reacted with thumbs up emoji

@codecov
Copy link

codecovbot commentedJul 21, 2021
edited
Loading

Codecov Report

Merging#3564 (96e0364) intomaster (eb453a5) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #3564   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          409       409             Lines        10264     10264           =========================================  Hits         10264     10264

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateeb453a5...96e0364. Read thecomment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit270cc2d at:https://60f818275bc56534a985a4cf--fastapi.netlify.app

auto-merge was automatically disabledJuly 21, 2021 16:22

Pull request was closed

@jalvaradosegura
Copy link
ContributorAuthor

More than happy to contribute to this incredible framework@tiangolo 🙇‍♂️

I have one question though. It seems that something is happening with thebuild-docs check, is taking quite a while.
I tried to solve this by closing and then opening the PR as stated in thisanswer

Is this normal? Am I not doing something? What should I do?

This is my first time contributing to a repository of this level, I'm tagging some of the FastAPI experts to kindly ask for their help🙏@Kludex@frankie567

@github-actions
Copy link
Contributor

📝 Docs preview for commit29fce2d at:https://615f0160201e9225059b0769--fastapi.netlify.app

@tiangolotiangoloenabled auto-merge (squash)October 7, 2021 14:29
@github-actions
Copy link
Contributor

📝 Docs preview for commit96e0364 at:https://615f04f14150f337c9f95e09--fastapi.netlify.app

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jalvaradosegura@tiangolo

[8]ページ先頭

©2009-2026 Movatter.jp