Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Conversation
codecovbot commentedJun 18, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #320 +/- ##===================================== Coverage 100% 100% ===================================== Files 224 224 Lines 5303 5303 ===================================== Hits 5303 5303
Continue to review full report at Codecov.
|
euri10 commentedJun 18, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
You need to update pyproject.toml to update the dependencies, pipfile is just for the dev setup iirc |
dmontagu commentedJun 18, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It might make sense to also add a (failing?) test for circular JSON schema references (outside of the main test folder? Maybe in |
tiangolo commentedJun 18, 2019
Thanks! Hehe, I have almost exactly the same in local WIP. I was planning to integrate right away Pydantic's ORM support, but let's keep them separated them. Let me check this. |
Thisfixes#307 and#308
Looks like the change to pydantic is required due to their changes to support circular JSON Schema references
pydantic/pydantic@d73aa1b#diff-7d11a8c77c4167b2958bcdb27b18cf2a
There is a decent chance I may be missing something, but simply passing an empty set for known_models passes all tests.
A better solution might be for pydantic to change the signature of
get_flat_models_from_fieldsto