Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

🔧 Configure strict pytest options and update/refactor tests#2790

Merged
tiangolo merged 10 commits intofastapi:masterfrom
graingert:configure-strict-pytest
Jul 19, 2021
Merged

🔧 Configure strict pytest options and update/refactor tests#2790
tiangolo merged 10 commits intofastapi:masterfrom
graingert:configure-strict-pytest

Conversation

@graingert
Copy link
Contributor

currently upstream is having to override pytest options to ignore these warningspydantic/pydantic#2337 (comment)

tiangolo reacted with heart emojitiangolo reacted with rocket emoji
@codecov
Copy link

codecovbot commentedFeb 10, 2021•
edited
Loading

Codecov Report

Merging#2790 (c36d79e) intomaster (00a8420) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@             Coverage Diff             @@##            master     #2790     +/-   ##===========================================  Coverage   100.00%   100.00%             ===========================================  Files          226       254     +28       Lines         6783      7855   +1072     ===========================================+ Hits          6783      7855   +1072
Impacted FilesCoverage Δ
tests/main.py100.00% <0.00%> (ø)
fastapi/utils.py100.00% <0.00%> (ø)
fastapi/params.py100.00% <0.00%> (ø)
fastapi/routing.py100.00% <0.00%> (ø)
fastapi/encoders.py100.00% <0.00%> (ø)
fastapi/requests.py100.00% <0.00%> (ø)
fastapi/responses.py100.00% <0.00%> (ø)
fastapi/exceptions.py100.00% <0.00%> (ø)
fastapi/concurrency.py100.00% <0.00%> (ø)
fastapi/applications.py100.00% <0.00%> (ø)
... and79 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update71c96d9...c36d79e. Read thecomment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit6cc34f1 at:https://60246ad88f4cb063c3e24d54--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 5f6d011a78f093ffb31cc1b451d3f6f7d78c7fe9 at:https://6024727aee9f6d6ae04972a0--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit9f50ab2 at:https://602473ee4692647992a3c062--fastapi.netlify.app

Copy link
Member

@tiangolotiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for all your work on this! 🙇 🤓

Thanks for improving the file handling and for the refactor topathlib, I love it. 🤩

I have mainly a couple of questions about the configs.

@tiangolotiangolo changed the titleconfigure strict pytest options🔧 Configure strict pytest optionsJul 5, 2021
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
@graingertgraingert requested a review fromtiangoloJuly 5, 2021 12:01
@github-actions
Copy link
Contributor

📝 Docs preview for commit7fcb5e5 at:https://60f5bb35a358f200aa49c7a3--fastapi.netlify.app

@graingert
Copy link
ContributorAuthor

@tiangolo Hello thanks for enabling my build!
There's a number of test failures, and I'd like to push fixes to them
I see you're currently working on my branch please can you let be know if you've finished

@tiangolo
Copy link
Member

Hey@graingert! Sure thing, go ahead! I just updated the docs that use that tutorial example to account for the changes, but that's done. And thanks a lot!

BTW, I commented out the pytest ignores to see if they would explode or not.

Also, I think the errors are because some recent tests used Pydantic models withTest in the name that were added in a recent PR. If you wanna fix those, that's awesome, but otherwise, you can just let me know and I can do it. 🤓

@graingert
Copy link
ContributorAuthor

graingert commentedJul 19, 2021 via email

Yep that looks like it to me, I'm happy for you to keep pushing to mybranch!
…
On Mon, 19 Jul 2021, 19:37 Sebastián Ramírez, ***@***.***> wrote: Hey@graingert <https://github.com/graingert>! Sure thing, go ahead! I just updated the docs that use that tutorial example to account for the changes, but that's done. And thanks a lot! BTW, I commented out the pytest ignores to see if they would explode or not. Also, I think the errors are because some recent tests used Pydantic models with Test in the name that were added in a recent PR. If you wanna fix those, that's awesome, but otherwise, you can just let me know and I can do it. 🤓 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2790 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADFATFCV2PXBLAUKNDHGG3TYRWHNANCNFSM4XN3E3GA> .
tiangolo reacted with thumbs up emoji

@github-actions
Copy link
Contributor

📝 Docs preview for commit69d69e2 at:https://60f5cb5495d61e00c8846e31--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit9bd72ae at:https://60f5cdda1fb0c60098118bb8--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commitc36d79e at:https://60f5cecd2ffa5f00e92a0ef5--fastapi.netlify.app

@tiangolotiangolo changed the title🔧 Configure strict pytest options🔧 Configure strict pytest options and update/refactor testsJul 19, 2021
@tiangolotiangolo merged commit2d296c5 intofastapi:masterJul 19, 2021
@graingertgraingert deleted the configure-strict-pytest branchJuly 19, 2021 19:18
PrettyWood added a commit to PrettyWood/pydantic that referenced this pull requestJul 19, 2021
Now thatfastapi/fastapi#2790 has been mergedin master, we don't need to filter those warnings anymore
samuelcolvin pushed a commit to pydantic/pydantic that referenced this pull requestJul 19, 2021
Now thatfastapi/fastapi#2790 has been mergedin master, we don't need to filter those warnings anymore
solomein-sv pushed a commit to solomein-sv/fastapi that referenced this pull requestJul 30, 2021
…2790)Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
tomasz-kaminski-jir pushed a commit to tomasz-kaminski-jir/pyd_analyze that referenced this pull requestMar 23, 2025
Now thatfastapi/fastapi#2790 has been mergedin master, we don't need to filter those warnings anymore
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tiangolotiangoloAwaiting requested review from tiangolo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@graingert@tiangolo

Comments

[8]ページ先頭
©2009-2026 Movatter.jp