fastapi/fastapiPublic

NotificationsYou must be signed in to change notification settings
Fork8.7k
Star95.4k

🌐 Add Japanese translation for Deployment - Docker#2312

Merged

tiangolo merged 4 commits intofastapi:masterfrom

tokusumi:translation/add-ja-deployment-docker

Feb 7, 2021

Merged

🌐 Add Japanese translation for Deployment - Docker#2312
tiangolo merged 4 commits intofastapi:masterfrom
tokusumi:translation/add-ja-deployment-docker

Conversation

Copy link

Contributor

tokusumi commentedNov 6, 2020•
edited
Loading

This PR translates deployment/docker.md in Japanese.

To all reviewers. This section is only separated from#1948 (with few changes), but please review it.

Add deployment/docker in Japanese

7ac04c7

Copy link

codecovbot commentedNov 6, 2020•
edited
Loading

Codecov Report

Merging#2312 (1e93bde) intomaster (f031973) willnot change coverage.
The diff coverage isn/a.

@@            Coverage Diff            @@##            master     #2312   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          243       243             Lines         7419      7419           =========================================  Hits          7419      7419

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatecb40e27...1e93bde. Read thecomment docs.

Copy link

Contributor

github-actionsbot commentedNov 6, 2020

📝 Docs preview for commit7ac04c7 at:https://5fa5337031aca1f4432e396a--fastapi.netlify.app

tokusumi mentioned this pull request

Nov 6, 2020

Japanese Translation#1572

Closed

tiangolo added awaiting-review lang-all

Translations

lang-jaJapanese translations labels

Nov 7, 2020

komtaki reviewed

Nov 8, 2020

View reviewed changes

Copy link

Contributor

komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank for your nice work.

I commented one suggestion.

docs/ja/docs/deployment/docker.md OutdatedShow resolvedHide resolved

Apply suggestions from code review

9a0e15a

Co-authored-by: Taki Komiyama <39375566+komtaki@users.noreply.github.com>

Copy link

ContributorAuthor

tokusumi commentedNov 8, 2020

Thank you for your review!

Copy link

Contributor

github-actionsbot commentedNov 8, 2020

📝 Docs preview for commit9a0e15a at:https://5fa7a72d8d2a1aebd5180f4a--fastapi.netlify.app

komtaki approved these changes

Nov 8, 2020

View reviewed changes

Copy link

Contributor

komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you : )

sh0nk reviewed

Jan 11, 2021

View reviewed changes

Copy link

Contributor

sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is my first time review on PRs. If I don't follow any convention etc., please kindly forget about the comments!

docs/ja/docs/deployment/docker.md OutdatedShow resolvedHide resolved

tokusumiand others added2 commits

January 12, 2021 06:54

Apply suggestions from code review

04144bb

Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>

Merge branch 'master' into translation/add-ja-deployment-docker

1e93bde

Copy link

Contributor

github-actionsbot commentedJan 11, 2021

📝 Docs preview for commit1e93bde at:https://5ffccaf90221081658744aa5--fastapi.netlify.app

Copy link

ContributorAuthor

tokusumi commentedJan 11, 2021

Thank you for your first review!@sh0nk
I applied your suggestions. Please check it again.

sh0nk approved these changes

Jan 12, 2021

View reviewed changes

Copy link

Contributor

sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fix. LGTM 👍

github-actionsbot added approved-2 and removed awaiting-review labels

Jan 12, 2021

Copy link

Member

tiangolo commentedFeb 7, 2021

Awesome@tokusumi ! 🚀 🍰

And thanks for the reviews@sh0nk and@komtaki ! 🙇 🍰 ☕

tiangolo merged commit08cbc6c intofastapi:master

Feb 7, 2021

tokusumi deleted the translation/add-ja-deployment-docker branch

May 5, 2021 08:10

tamtam-fitness mentioned this pull request

Aug 13, 2023

🌐 Update Japanese translation fordocs/ja/docs/deployment/docker.md#10073

Merged

Labels

approved-2 lang-all

Translations

lang-ja

Japanese translations

Movatterモバイル変換

Uh oh!

Conversation

tokusumi commentedNov 6, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedNov 6, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsbot commentedNov 6, 2020

Uh oh!

komtaki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tokusumi commentedNov 8, 2020

Uh oh!

github-actionsbot commentedNov 8, 2020

Uh oh!

komtaki left a comment

Choose a reason for hiding this comment

Uh oh!

sh0nk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsbot commentedJan 11, 2021

Uh oh!

tokusumi commentedJan 11, 2021

Uh oh!

sh0nk left a comment

Choose a reason for hiding this comment

Uh oh!

tiangolo commentedFeb 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

tokusumi commentedNov 6, 2020•
edited
Loading

codecovbot commentedNov 6, 2020•
edited
Loading