fastapi/fastapiPublic

NotificationsYou must be signed in to change notification settings
Fork8.7k
Star95.4k

Comments

🌐 Add Japanese translation for Tutorial - Testing#2259

Merged

tiangolo merged 5 commits intofastapi:masterfrom

tokusumi:translation/add-ja-tutorial-testing

Feb 7, 2021

Merged

🌐 Add Japanese translation for Tutorial - Testing#2259
tiangolo merged 5 commits intofastapi:masterfrom
tokusumi:translation/add-ja-tutorial-testing

Conversation

Copy link

Contributor

tokusumi commentedOct 28, 2020

This PR translates tutorial/testing.md in Japanese.

Add Japanese translation for tutorial/testing

fab4df7

tokusumi mentioned this pull request

Oct 28, 2020

Japanese Translation#1572

Closed

Copy link

codecovbot commentedOct 28, 2020•
edited
Loading

Codecov Report

Merging#2259 (8336fa6) intomaster (17781e3) willnot change coverage.
The diff coverage isn/a.

@@            Coverage Diff            @@##            master     #2259   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          243       243             Lines         7419      7419           =========================================  Hits          7419      7419

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec88fb2e...8336fa6. Read thecomment docs.

Copy link

Contributor

github-actionsbot commentedOct 28, 2020

📝 Docs preview for commitfab4df7 at:https://5f99769450c750b68b9ce278--fastapi.netlify.app

tiangolo added awaiting-review hacktoberfest-accepted lang-all

Translations

lang-jaJapanese translations labels

Nov 1, 2020

komtaki reviewed

Nov 3, 2020

View reviewed changes

Copy link

Contributor

komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your work. 👍

I suggested one minor change.

docs/ja/docs/tutorial/testing.md OutdatedShow resolvedHide resolved

Update docs/ja/docs/tutorial/testing.md

6af5432

Co-authored-by: Taki Komiyama <39375566+komtaki@users.noreply.github.com>

Copy link

ContributorAuthor

tokusumi commentedNov 3, 2020

Thank you for your review!

Copy link

Contributor

github-actionsbot commentedNov 3, 2020

📝 Docs preview for commit6af5432 at:https://5fa0c762a2b1c44c38431da5--fastapi.netlify.app

komtaki approved these changes

Nov 3, 2020

View reviewed changes

Copy link

Contributor

komtaki left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

sh0nk reviewed

Jan 11, 2021

View reviewed changes

Copy link

Contributor

sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a single typo. The others look good!

docs/ja/docs/tutorial/testing.md OutdatedShow resolvedHide resolved

tokusumiand others added2 commits

January 12, 2021 06:39

Update docs/ja/docs/tutorial/testing.md

c93ae87

Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>

Merge branch 'master' into translation/add-ja-tutorial-testing

6c11914

Copy link

Contributor

github-actionsbot commentedJan 11, 2021

📝 Docs preview for commit6c11914 at:https://5ffcd77a49593800ddf21b8d--fastapi.netlify.app

Copy link

ContributorAuthor

tokusumi commentedJan 11, 2021

Thank you@sh0nk for your review!
I applied your suggestion. Please check it again.

sh0nk approved these changes

Jan 12, 2021

View reviewed changes

Copy link

Contributor

sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

github-actionsbot added approved-2 and removed awaiting-review labels

Jan 12, 2021

Merge branch 'master' into translation/add-ja-tutorial-testing

8336fa6

Copy link

Member

tiangolo commentedFeb 7, 2021

Awesome@tokusumi ! 👏 👏 🚀

And thanks a lot@sh0nk and@komtaki as always for the reviews. 🙇 ☕

Copy link

Contributor

github-actionsbot commentedFeb 7, 2021

📝 Docs preview for commit8336fa6 at:https://60202373095b3221539e3697--fastapi.netlify.app

tiangolo merged commitcd8b90a intofastapi:master

Feb 7, 2021

tokusumi deleted the translation/add-ja-tutorial-testing branch

May 5, 2021 08:12

Labels

approved-2 hacktoberfest-accepted lang-all

Translations

lang-ja

Japanese translations

Movatterモバイル変換

Uh oh!

Comments

Conversation

tokusumi commentedOct 28, 2020

Uh oh!

codecovbot commentedOct 28, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsbot commentedOct 28, 2020

Uh oh!

komtaki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tokusumi commentedNov 3, 2020

Uh oh!

github-actionsbot commentedNov 3, 2020

Uh oh!

komtaki left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sh0nk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actionsbot commentedJan 11, 2021

Uh oh!

tokusumi commentedJan 11, 2021

Uh oh!

sh0nk left a comment

Choose a reason for hiding this comment

Uh oh!

tiangolo commentedFeb 7, 2021

Uh oh!

github-actionsbot commentedFeb 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecovbot commentedOct 28, 2020•
edited
Loading

komtaki left a comment•
edited
Loading