Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
Use a logger instead of the root logging#222
Merged
tiangolo merged 13 commits intofastapi:masterfromMay 15, 2019
euri10:logger
Merged
Use a logger instead of the root logging#222tiangolo merged 13 commits intofastapi:masterfromeuri10:logger
tiangolo merged 13 commits intofastapi:masterfrom
euri10:logger
Conversation
codecovbot commentedMay 14, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #222 +/- ##===================================== Coverage 100% 100% ===================================== Files 170 170 Lines 4122 4123 +1 =====================================+ Hits 4122 4123 +1
Continue to review full report at Codecov.
|
tiangolo requested changesMay 15, 2019
Member
tiangolo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
Just a small change.
Uh oh!
There was an error while loading.Please reload this page.
Member
tiangolo commentedMay 15, 2019
Thanks! 🎉 🚀 |
lmignon pushed a commit to acsone/fastapi that referenced this pull requestSep 19, 2024
Signed-off-by lmignon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root logger shouldn't be used
https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library