fastapi/fastapiPublic

NotificationsYou must be signed in to change notification settings
Fork8.7k
Star95.4k

🌐 Add Japanese translation for Advanced Tutorial - Response Directly#2191

Merged

tiangolo merged 6 commits intofastapi:masterfrom

Attsun1031:translation/add-japanese-doc-advance-response-directly

Nov 5, 2020

Merged

🌐 Add Japanese translation for Advanced Tutorial - Response Directly#2191
tiangolo merged 6 commits intofastapi:masterfrom
Attsun1031:translation/add-japanese-doc-advance-response-directly

Conversation

Copy link

Contributor

Attsun1031 commentedOct 18, 2020

This PR translates the advanced/response-directly.md to Japanese.

Attsun1031 added2 commits

October 18, 2020 14:32

Add Japanese translation for Advanced - response-directly

88e4e98

Merge branch 'master' into translation/add-japanese-doc-advance-respo…

b04a24d

…nse-directly

Attsun1031 mentioned this pull request

Oct 18, 2020

Japanese Translation#1572

Closed

Copy link

codecovbot commentedOct 18, 2020•
edited
Loading

Codecov Report

Merging#2191 intomaster willnot change coverage.
The diff coverage isn/a.

@@            Coverage Diff            @@##            master     #2191   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          240       240             Lines         7101      7101           =========================================  Hits          7101      7101

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update790fa21...30234f4. Read thecomment docs.

Copy link

Contributor

github-actionsbot commentedOct 18, 2020

📝 Docs preview for commitb04a24d at:https://5f8bddc92ff9405832abf230--fastapi.netlify.app

Merge branch 'master' into translation/add-japanese-doc-advance-respo…

7f66de3

…nse-directly

Copy link

Contributor

github-actionsbot commentedOct 18, 2020

📝 Docs preview for commit7f66de3 at:https://5f8beb99f3a8268708266a0e--fastapi.netlify.app

tiangolo added awaiting-review lang-all

Translations

lang-ja

Japanese translations

hacktoberfest-accepted labels

Oct 18, 2020

tokusumi suggested changes

Oct 29, 2020

View reviewed changes

Copy link

Contributor

tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for great work!

docs/ja/docs/advanced/response-directly.md OutdatedShow resolvedHide resolved

Apply suggestions from code review

2a31143

Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>

Copy link

ContributorAuthor

Attsun1031 commentedOct 30, 2020

@tokusumi Thank you for your review ! Every your suggestion are applied, so please check again.

Copy link

Contributor

github-actionsbot commentedOct 30, 2020

📝 Docs preview for commit2a31143 at:https://5f9b6bc2a324101c9bb41006--fastapi.netlify.app

tokusumi approved these changes

Oct 30, 2020

View reviewed changes

Copy link

Contributor

tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for cooperating!

komtaki reviewed

Nov 2, 2020

View reviewed changes

Copy link

Contributor

komtaki left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank your for your work. 👍

I commented a few small suggestions.

docs/ja/docs/advanced/response-directly.md OutdatedShow resolvedHide resolved

Apply suggestions from code review

c78712e

Co-authored-by: Taki Komiyama <39375566+komtaki@users.noreply.github.com>

Copy link

ContributorAuthor

Attsun1031 commentedNov 4, 2020

@komtaki Thank you for your review ! I fixed everything, so please check again.

Copy link

Contributor

github-actionsbot commentedNov 4, 2020

📝 Docs preview for commitc78712e at:https://5fa21758817493444118613f--fastapi.netlify.app

komtaki approved these changes

Nov 4, 2020

View reviewed changes

Copy link

Contributor

komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for update 👍

github-actionsbot added approved-2 and removed awaiting-review labels

Nov 5, 2020

tiangolo changed the title~~Add Japanese translation for Advanced - response-directly~~🌐 Add Japanese translation for Advanced Tutorial - Response Directly

Nov 5, 2020