Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
📝 Fix code consistency in examples for Tutorial - User Guide - Path Parameters#2158
Merged
tiangolo merged 4 commits intofastapi:masterfromNov 5, 2020
Merged
Conversation
Member
Kludex commentedOct 10, 2020
The pipeline is failing because the tests are calling |
codecovbot commentedOct 10, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2158 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 239 239 Lines 7079 7079 ========================================= Hits 7079 7079
Continue to review full report at Codecov.
|
Author
nukopy commentedOct 10, 2020
Thanks. I fixed tests. |
docs_src in "Tutorial - User Guide"docs_src in "Tutorial - User Guide"Contributor
📝 Docs preview for commite131337 at:https://5f8224071a19b43513081953--fastapi.netlify.app |
docs_src in "Tutorial - User Guide"Member
tiangolo commentedNov 5, 2020
Nice! Good catch, thank you! 🚀 🎉 Thanks@Kludex for the help! 💪 🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I found typos in the chapter "Path Parameters" in "Tutorial - User Guide".
What
Endpoint's path
modelinexample code should be a plural form,models.I fixed below:
docs_src/path_params/tutoial005.pydocs/en/docs/img/tutorial/image03.png