Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

🌐 Add Japanese translation for Advanced - Path Operation Advanced Configuration#2124

Merged
tiangolo merged 6 commits intofastapi:masterfrom
Attsun1031:translation/add-japanese-doc-advance-path-ops
Jan 9, 2021
Merged

🌐 Add Japanese translation for Advanced - Path Operation Advanced Configuration#2124
tiangolo merged 6 commits intofastapi:masterfrom
Attsun1031:translation/add-japanese-doc-advance-path-ops

Conversation

@Attsun1031
Copy link
Contributor

This PR translates the advanced/path-operation-advanced-configuration.md to Japanese.
Please review advanced/path-operation-advanced-configuration.md and ja/mkdocs.yml.

@codecov
Copy link

codecovbot commentedOct 3, 2020•
edited
Loading

Codecov Report

Merging#2124 (3066853) intomaster (54eeb31) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #2124   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          243       243             Lines         7419      7419           =========================================  Hits          7419      7419

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated2eb4a7...3066853. Read thecomment docs.

@Attsun1031Attsun1031 mentioned this pull requestOct 3, 2020
@Attsun1031Attsun1031force-pushed thetranslation/add-japanese-doc-advance-path-ops branch fromae494ca toc6ecd33CompareOctober 3, 2020 07:43
@Attsun1031Attsun1031force-pushed thetranslation/add-japanese-doc-advance-path-ops branch fromc6ecd33 to69a62abCompareOctober 3, 2020 07:45
@github-actions
Copy link
Contributor

📝 Docs preview for commit69a62ab at:https://5f7832c683304ee2b4f88cd7--fastapi.netlify.app

Copy link
Contributor

@tokusumitokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thank you for great work. I commented some feedback.

Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@Attsun1031
Copy link
ContributorAuthor

@tokusumi Thank you for your nice suggestions ! I've fix everything, so please check again.

tokusumi reacted with thumbs up emoji

@github-actions
Copy link
Contributor

📝 Docs preview for commit3f5463a at:https://5f79845cc2c10c910d740a16--fastapi.netlify.app

@Attsun1031
Copy link
ContributorAuthor

I resolved all conflicts (All were mkdocs nav order)
e381456

tokusumi reacted with thumbs up emoji

@github-actions
Copy link
Contributor

📝 Docs preview for commite381456 at:https://5f8bf9e12ff9408589abed7c--fastapi.netlify.app

Copy link
Contributor

@tokusumitokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sorry for late response.
great work!

Attsun1031 reacted with heart emoji
@tokusumi
Copy link
Contributor

@tiangolo, This PR is Japanese tlanslation. could you add some labels?

tiangolo reacted with heart emoji

@tiangolotiangolo added awaiting-review lang-allTranslations lang-jaJapanese translations labelsNov 5, 2020
Copy link

@delhi09delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks mostly good.
I pointed out some details.

!!! warning "注意"
あなたがOpenAPIの「エキスパート」でなければ、これは必要ないかもしれません。

*path operation* で `operationId` パラメータを利用することで、OpenAPIの `operationId` を設定できます。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

First "operationId" should be "operation_id" because its's Python's arg name.

Attsun1031 reacted with thumbs up emoji

*path operation* で `operationId` パラメータを利用することで、OpenAPIの `operationId` を設定できます。

各オペレーションで一意にする必要があります。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In my opinion, Its' a little better to add "operationIdは" before "各オペレーションで" because I feel the subject of the sentence is a little difficult to understand.

Attsun1031 reacted with thumbs up emoji
@Attsun1031
Copy link
ContributorAuthor

@delhi09 Thank you for your nice suggestions ! I've fix everything, so please check again.

@github-actions
Copy link
Contributor

📝 Docs preview for commit3066853 at:https://5ff7c1601449a800901f78cd--fastapi.netlify.app

Copy link

@delhi09delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM！

@tiangolotiangolo changed the titleAdd advanced/path-operation-advanced-configuration.md Japanese ver.🌐 Add Japanese translation for Advanced - Path Operation Advanced ConfigurationJan 9, 2021
@tiangolo
Copy link
Member

Great! Thanks@Attsun1031 ! 🙇 🚀

And thanks@tokusumi and@delhi09 for the reviews 🔍 🍰

Attsun1031 reacted with laugh emoji

@tiangolotiangolo merged commit5a4a61c intofastapi:masterJan 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@tokusumitokusumitokusumi approved these changes

@delhi09delhi09delhi09 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2hacktoberfest-acceptedlang-allTranslationslang-jaJapanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Attsun1031@tokusumi@tiangolo@delhi09

Comments

[8]ページ先頭
©2009-2026 Movatter.jp