Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

🌐 Add Japanese translation for History Design and Future#2002

Merged
tiangolo merged 6 commits intofastapi:masterfrom
komtaki:translation/add-japanese-doc-history-design-future
Oct 18, 2020
Merged

🌐 Add Japanese translation for History Design and Future#2002
tiangolo merged 6 commits intofastapi:masterfrom
komtaki:translation/add-japanese-doc-history-design-future

Conversation

@komtaki
Copy link
Contributor

@komtakikomtaki commentedSep 2, 2020•
edited
Loading

This PR translates the history-design-future.md to Japanese.

According to the issue:#1572

Thanks!!

@komtakikomtaki changed the titleAdd japanese doc history-design-future.mdAdd history-design-future.md Japanese ver.Sep 2, 2020
@codecov
Copy link

codecovbot commentedSep 2, 2020•
edited
Loading

Codecov Report

Merging#2002 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #2002   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          239       239             Lines         7079      7079           =========================================  Hits          7079      7079

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatecb55d7c...883fc4b. Read thecomment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 32f62e7cfd14750e2e7e876ca36a20cf12dd72bb at:https://5f4f61f91b2e0974afc3ac0a--fastapi.netlify.app

@komtakikomtakiforce-pushed thetranslation/add-japanese-doc-history-design-future branch from32f62e7 to0cba83cCompareSeptember 4, 2020 13:25
@komtakikomtaki marked this pull request as ready for reviewSeptember 4, 2020 13:26
@komtakikomtaki mentioned this pull requestSep 4, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit0cba83c at:https://5f5267a6a13a211201097a70--fastapi.netlify.app

@komtaki
Copy link
ContributorAuthor

@tokusumi

Thanks for the review!! 👍
I fixed everything. So, check my fix please.

Copy link
Contributor

@tokusumitokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@github-actions
Copy link
Contributor

📝 Docs preview for commit5054408 at:https://5f5db8ada9ea4d5136e47462--fastapi.netlify.app

Copy link
Contributor

@Attsun1031Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your translation ! Most of the translation felt okay,

I commented only about the consistency with alternatives.md translation.

tokusumi reacted with thumbs up emoji
@komtaki
Copy link
ContributorAuthor

komtaki commentedSep 27, 2020•
edited
Loading

@Attsun1031

Thank you for your review. 👍
I fixed to match to#2043

Please check my fix.

@github-actions
Copy link
Contributor

📝 Docs preview for commit78c5948 at:https://5f70578e4936ac987f449091--fastapi.netlify.app

Copy link
Contributor

@Attsun1031Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM👍

@tokusumi
Copy link
Contributor

Hi,@tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

tiangolo reacted with thumbs up emoji

@Mause
Copy link
Contributor

I believe@tiangolo is currently moving houses, so you'll have to be patient

tiangolo reacted with thumbs up emojitiangolo reacted with heart emoji

@tokusumi
Copy link
Contributor

Oops. I'm really sorry for annoying notification 🙇

tiangolo reacted with heart emoji

@tiangolotiangolo added awaiting-review lang-allTranslations lang-jaJapanese translations labelsOct 15, 2020
@tiangolotiangolo changed the titleAdd history-design-future.md Japanese ver.🌐 Add Japanese translation for History Design and FutureOct 18, 2020
@tiangolotiangolo merged commitf2c565d intofastapi:masterOct 18, 2020
@tiangolo
Copy link
Member

Great! Thank you@komtaki ! 🙇 ☕

Thanks for the reviews@Attsun1031 and@tokusumi ! 🍰 🤓

And thanks@Mause for helping with the clarification! 😄 Indeed, finding a flat in Berlin is quite difficult and has a bunch of complications... I'm still waiting for the internet connection to be installed in my house 😅

But also thanks@tokusumi for pointing out the broken bot 🤦‍♂️ I wrote one to replace it and it should work fine from now on 🤖 🚀

tokusumi reacted with rocket emoji

@komtakikomtaki deleted the translation/add-japanese-doc-history-design-future branchOctober 19, 2020 14:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@Attsun1031Attsun1031Attsun1031 approved these changes

@tokusumitokusumitokusumi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-jaJapanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@komtaki@tokusumi@Mause@tiangolo@Attsun1031
[8]ページ先頭
©2009-2026 Movatter.jp