Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

🌐 Add Japanese translation fordocs/ja/docs/tutorial/response-status-code.md#1942

Merged
alejsdev merged 30 commits intofastapi:masterfrom
SwftAlpc:translation/ja-tutorial-response-status-code-md
Jan 15, 2024
Merged

🌐 Add Japanese translation fordocs/ja/docs/tutorial/response-status-code.md#1942
alejsdev merged 30 commits intofastapi:masterfrom
SwftAlpc:translation/ja-tutorial-response-status-code-md

Conversation

@SwftAlpc
Copy link
Contributor

@SwftAlpcSwftAlpc commentedAug 21, 2020•
edited
Loading

This PR translates the tutorial/response-status-code.md to Japanese.
Please review tutorial/response-status-code.md.

Issue#1571 generates a new directory to support Japanese.
PR#1656 generates a new directory for tutorial.
I will fix dependency after#1571 &#1656 are merged.

ycd reacted with thumbs up emojiycd reacted with hooray emojiycd reacted with heart emojiycd reacted with rocket emoji
@SwftAlpcSwftAlpc mentioned this pull requestAug 21, 2020
@codecov
Copy link

codecovbot commentedAug 21, 2020•
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base(cf73051) 100.00% compared to head(2e95898) 100.00%.

❗ Current head2e95898 differs from pull request most recent headafa65b7. Consider uploading reports for the commitafa65b7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@##            master     #1942     +/-   ##===========================================  Coverage   100.00%   100.00%             ===========================================  Files          540       239    -301       Lines        13969      7079   -6890     ===========================================- Hits         13969      7079   -6890

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment?Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit22f8861 at:https://5f3ff22c5c652e24b3592495--fastapi.netlify.app

@tiangolotiangolo added awaiting-review lang-allTranslations lang-jaJapanese translations labelsAug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit31a534e at:https://5f4cbf4e5bf93092ddad3227--fastapi.netlify.app

SwftAlpcand others added5 commitsOctober 29, 2020 20:39
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
SwftAlpcand others added7 commitsOctober 29, 2020 20:41
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
…hub.com:SwftAlpc/fastapi into translation/ja-tutorial-response-status-code-md
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@SwftAlpc
Copy link
ContributorAuthor

@tokusumi
Thanks for the review!
May I ask for a second review and approval?

tokusumi reacted with hooray emoji

@github-actions
Copy link
Contributor

📝 Docs preview for commit2e95898 at:https://5f9aab908b8d8321f2fcef08--fastapi.netlify.app

Copy link
Contributor

@tokusumitokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for accepting my suggestions🎉

Copy link

@delhi09delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks mostly good.
I pointed out some details.

* `@app.post()`
* `@app.put()`
* `@app.delete()`
* など。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I feel it's a little unnatural for translating "etc" to "など" and I think it may be kept an English word "etc".


つまり:

* `100`以上は「情報」のためのものです。。直接使うことはほとんどありません。これらのステータスコードを持つレスポンスはボディを持つことができません。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

a "。" is duplicated.

{!../../../docs_src/response_status_code/tutorial002.py!}
```

それらは便利です。それらは同じ番号を保持しており、その方法ではエディタの自動補完を使用してそれらを見つけることができます。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • It's better to modify "保持しており" to "保持していますが" because "but" is used as a conjunction in the original sentence.
  • In my opinion, It's better to modify the first "それら" to "fastapi.statusの変数" and "その方法" to "`それらの変数を使用する方法" because "それ" or "その" appears three times make the sentence a little difficult to read.

@tiangolotiangolo changed the titleAdd tutorial/response-status-code.md Japanese ver.🌐 Add Japanese translation fordocs/ja/docs/tutorial/response-status-code.mdJun 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commitafa65b7 at:https://6499caf4706d0c04fc5a1966--fastapi.netlify.app

@alejsdev
Copy link
Member

Thanks@SwftAlpc 🤓

And thanks for reviewing@tokusumi 🔍

@alejsdevalejsdev merged commit88225ae intofastapi:masterJan 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@delhi09delhi09delhi09 left review comments

@tokusumitokusumitokusumi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-reviewlang-allTranslationslang-jaJapanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SwftAlpc@tiangolo@alejsdev@tokusumi@delhi09@ryuckel
[8]ページ先頭
©2009-2026 Movatter.jp