Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

🌐 Add Japanese translation for tutorial/path-params.md#1671

Merged
tiangolo merged 15 commits intofastapi:masterfrom
tokusumi:translation/add-japanese-tutorial-path-params
Oct 17, 2020
Merged

🌐 Add Japanese translation for tutorial/path-params.md#1671
tiangolo merged 15 commits intofastapi:masterfrom
tokusumi:translation/add-japanese-tutorial-path-params

Conversation

@tokusumi
Copy link
Contributor

@tokusumitokusumi commentedJul 5, 2020•
edited
Loading

This PR translates the tutorial/path-params.md to Japanese.
Please review tutorial/path-params.md

Issue#1571 generates a new directory to support Japanese.
I will fix dependency after#1571 is merged.

@tokusumitokusumi mentioned this pull requestJul 5, 2020
@tiangolotiangolo added lang-allTranslations lang-jaJapanese translations awaiting-review labelsJul 10, 2020
@codecov
Copy link

codecovbot commentedAug 15, 2020•
edited
Loading

Codecov Report

Merging#1671 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #1671   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          239       239             Lines         7079      7079           =========================================  Hits          7079      7079

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update3d76700...5413ee4. Read thecomment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit4d7a4e5 at:https://5f37deb8fded4343d1946d7e--fastapi.netlify.app

Copy link
Contributor

@SwftAlpcSwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the translation!
We need to make some corrections.
Please check.

tokusumi reacted with heart emoji
@github-actions
Copy link
Contributor

📝 Docs preview for commit3a9a218 at:https://5f38171b469979b51113539e--fastapi.netlify.app

Copy link
Contributor

@SwftAlpcSwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

tokusumi reacted with rocket emoji
Copy link
Contributor

@ryuckelryuckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

tokusumi reacted with rocket emoji
@github-actions
Copy link
Contributor

📝 Docs preview for commitfdecb70 at:https://5f4a7079281ab6fafb5f5d35--fastapi.netlify.app

@tokusumi
Copy link
ContributorAuthor

Hi,@tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@tiangolotiangolo changed the titleAdd Japanese translation for tutorial/path-params.md🌐 Add Japanese translation for tutorial/path-params.mdOct 17, 2020
@tiangolo
Copy link
Member

This is amazing! Thanks for all the work you have been doing with this@tokusumi ! 👏 👏 🙇 ☕

And thanks@ryuckel and@SwftAlpc for the reviews! 🍰 🤓

@tiangolotiangolo merged commit4530456 intofastapi:masterOct 17, 2020
@tokusumitokusumi deleted the translation/add-japanese-tutorial-path-params branchJanuary 18, 2021 09:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@ryuckelryuckelryuckel approved these changes

@SwftAlpcSwftAlpcSwftAlpc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-jaJapanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi@tiangolo@ryuckel@SwftAlpc
[8]ページ先頭
©2009-2026 Movatter.jp