Movatterモバイル変換

Skip to content

fastapi/fastapiPublic

NotificationsYou must be signed in to change notification settings
Fork8.7k
Star95.4k

Add support for adding OpenAPI schema for GET requests with a body#1626

Merged

tiangolo merged 4 commits intofastapi:masterfrom

victorphoenix3:get

Jul 19, 2020

Merged

Add support for adding OpenAPI schema for GET requests with a body#1626
tiangolo merged 4 commits intofastapi:masterfrom
victorphoenix3:get

Conversation

@victorphoenix3

Copy link

Contributor

victorphoenix3 commentedJun 25, 2020•
edited by tiangolo
Loading

Related to#713 .

@victorphoenix3

victorphoenix3 force-pushed theget branch from8f5f97a to318b658Compare

June 25, 2020 17:36

@codecov

Copy link

codecovbot commentedJun 25, 2020•
edited
Loading

Codecov Report

Merging#1626 intomaster willnot change coverage.
The diff coverage is100.00%.

@@            Coverage Diff             @@##            master     #1626    +/-   ##==========================================  Coverage   100.00%   100.00%            ==========================================  Files          227       239    +12       Lines         6810      7047   +237     ==========================================+ Hits          6810      7047   +237

Impacted Files	Coverage Δ
fastapi/dependencies/utils.py	`100.00% <100.00%> (ø)`
fastapi/openapi/constants.py	`100.00% <100.00%> (ø)`
tests/test_get_request_body.py	`100.00% <100.00%> (ø)`
tests/main.py	`100.00% <0.00%> (ø)`
fastapi/utils.py	`100.00% <0.00%> (ø)`
fastapi/params.py	`100.00% <0.00%> (ø)`
fastapi/routing.py	`100.00% <0.00%> (ø)`
tests/test_path.py	`100.00% <0.00%> (ø)`
fastapi/encoders.py	`100.00% <0.00%> (ø)`
tests/test_query.py	`100.00% <0.00%> (ø)`
... and91 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update543ef77...7ba8167. Read thecomment docs.

@victorphoenix3

Copy link

ContributorAuthor

victorphoenix3 commentedJun 25, 2020

@IamCathal could you take a look at this?

rkbeatss

rkbeatss reviewed

View reviewed changes

tests/test_get_request_body_schema.py Outdated

Copy link

Contributor

rkbeatssJun 25, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@victorphoenix3 i think this is where the coverage is missing so try adding# pragma: no cover here

Copy link

ContributorAuthor

victorphoenix3Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hey thanks@rkbeatss . It worked!

Copy link

Member

tiangoloJul 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the help@rkbeatss ! 🤓

@victorphoenix3

victorphoenix3 force-pushed theget branch 3 times, most recently fromf416e25 to065be3cCompare

July 2, 2020 08:57

@victorphoenix3

add test for get request body's openapi schema

17f4bcf

@victorphoenix3

victorphoenix3 force-pushed theget branch from065be3c to17f4bcfCompare

July 2, 2020 09:08

@victorphoenix3

Copy link

ContributorAuthor

victorphoenix3 commentedJul 2, 2020

@tiangolo The PR is ready for review.

@Kludex

Kludex mentioned this pull request

Support request bodies for GET requests?#1691

Closed

9 tasks

tiangolo added2 commits

July 19, 2020 11:29

@tiangolo

📝 Update docs note for GET requests with body

79ab859

@tiangolo

✅ Update test for GET request with body, test it receives the body

ddb3ad5

@tiangolo

tiangolo changed the title~~Add Test for get request body's openapi schema~~Add support for adding OpenAPI schema for GET requests with a body

@tiangolo

🔇 Temporary type ignore while it's handled in Pydantic

7ba8167

@tiangolo

tiangolo merged commit2b47f3e intofastapi:master

@tiangolo

Copy link

Member

tiangolo commentedJul 19, 2020

Awesome@victorphoenix3 ! 🚀 🎉

I updated the test to check that it actually can receive a body in aGET request and to keep the same style of testing OpenAPI from other tests.

Thanks for your contribution! 🍰 🎉

@tiangolo

tiangolo mentioned this pull request

Support body in GET and other methods with undefined behavior#713

Closed

@Kludex

Kludex mentioned this pull request

Allow JSON payload for GET calls#2004

Closed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

3 participants

@victorphoenix3

@tiangolo

@rkbeatss

Comments

[8]ページ先頭

©2009-2026 Movatter.jp