Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

🌐 Add Japanese translation for Features#1625

Merged
tiangolo merged 15 commits intofastapi:masterfrom
tokusumi:feature/japanese-features-md
Oct 16, 2020
Merged

🌐 Add Japanese translation for Features#1625
tiangolo merged 15 commits intofastapi:masterfrom
tokusumi:feature/japanese-features-md

Conversation

@tokusumi
Copy link
Contributor

@tokusumitokusumi commentedJun 25, 2020•
edited
Loading

This PR translates the features.md to Japanese.
Please review features.md.

Issue#1571 generates a new directory to support Japanese.
I will fix dependency after#1571 is merged.

@codecov
Copy link

codecovbot commentedJun 25, 2020•
edited
Loading

Codecov Report

Merging#1625 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #1625   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          239       239             Lines         7079      7079           =========================================  Hits          7079      7079

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatedfdd371...b333f1a. Read thecomment docs.

@tokusumitokusumi mentioned this pull requestJun 25, 2020
@tiangolotiangolo added awaiting-review lang-allTranslations lang-jaJapanese translations labelsJun 27, 2020
Copy link
Contributor

@SwftAlpcSwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the excellent translation.
There are a few things that I noticed and I would like to suggest some corrections.

tokusumi reacted with heart emoji

FastAPIには非常に使いやすく、非常に強力な<abbr title='also known as "components", "resources", "services", "providers"'><strong>依存性の注入</strong></abbr>システムを備えています。

* 階層または **依存関係の"グラフ"** を作成することで、依存関係でさえも依存関係を持つことができます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

依存関係でさえも依存関係を持つことができ、階層または依存関係の"グラフ” を作成することができます。

tokusumi reacted with thumbs up emoji
@tokusumi
Copy link
ContributorAuthor

@SwftAlpc Thank you for your good suggestions. I improved translation. Please re-review and approve this PR if you want.

SwftAlpc reacted with hooray emoji

Copy link
Contributor

@SwftAlpcSwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the quick response.
LGTM!

tokusumi reacted with rocket emoji
@github-actions
Copy link
Contributor

📝 Docs preview for commitdfbf133 at:https://5f37c2ae1c8489711bfacd42--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit6013a0b at:https://5f37d177fb8f784b80f53a47--fastapi.netlify.app

@tokusumitokusumi marked this pull request as ready for reviewAugust 16, 2020 22:58
@ryuckel
Copy link
Contributor

LGTM!

tokusumi reacted with rocket emoji

@github-actions
Copy link
Contributor

📝 Docs preview for commitb333f1a at:https://5f4a62593025493347748637--fastapi.netlify.app

@tokusumi
Copy link
ContributorAuthor

Hi,@tiangolo
This PR has been approved by two reviewers (github actions to label approved PR didn't work, though).
Would you like to require something more for this to be merged?

@tiangolotiangolo changed the titleAdd Japanese translation for features.md🌐 Add Japanese translation for FeaturesOct 16, 2020
@tiangolotiangolo merged commit74f13e5 intofastapi:masterOct 16, 2020
@tiangolo
Copy link
Member

Awesome! Thank you@tokusumi ! 🙇 🍰

And thank you@ryuckel and@SwftAlpc for the reviews 👏 ☕

Indeed, the GitHub action to manage the labels wasn't working correctly, so I just created a new one that is finally working 😄 🤖

@tokusumitokusumi deleted the feature/japanese-features-md branchOctober 17, 2020 01:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@ryuckelryuckelryuckel approved these changes

@SwftAlpcSwftAlpcSwftAlpc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-jaJapanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tokusumi@ryuckel@tiangolo@SwftAlpc

Comments

[8]ページ先頭
©2009-2026 Movatter.jp