Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Remove duplicate chinese articles#1510

Merged
tiangolo merged 1 commit intofastapi:masterfrom
waynerv:remove-duplicate-chinese-articles
Jun 13, 2020
Merged

Remove duplicate chinese articles#1510
tiangolo merged 1 commit intofastapi:masterfrom
waynerv:remove-duplicate-chinese-articles

Conversation

@waynerv
Copy link
Contributor

Since the content of the 2 Chinese articles in External Links and Articles is very simple, just a brief summary of 1 or 2 document chapters, as we now have some more detailed Chinese translation of docs, I suggest temporarily removing these 2 duplicate articles.

@codecov
Copy link

codecovbot commentedJun 4, 2020
edited
Loading

Codecov Report

Merging#1510 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #1510   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          227       227             Lines         6805      6810    +5     =========================================+ Hits          6805      6810    +5
Impacted FilesCoverage Δ
fastapi/utils.py100.00% <0.00%> (ø)
fastapi/openapi/utils.py100.00% <0.00%> (ø)
fastapi/dependencies/utils.py100.00% <0.00%> (ø)
...test_tutorial/test_path_params/test_tutorial005.py100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update601d8eb...e429752. Read thecomment docs.

@tiangolo
Copy link
Member

I guess that would make sense 🔥

But as I don't really know the language I would like a second opinion, just to be sure. Maybe@yanever ,@Laineyzhang55 ,@phy25,@Dustyposa ,@RunningIkkyu , what do you think?

RunningIkkyu reacted with thumbs up emoji

Copy link

@phy25phy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The first link is a very, very simple introduction. The second one is a blog's index page containing some fastapi-related articles, some of which is purely translation and some of which is the author's learning notes.

I would not say they are "duplicate", but they are not a complete walkthrough, or insight in a specific aspect. The translation of the docs should already been better than them. Just my personal opinion.

tiangolo and waynerv reacted with thumbs up emojitiangolo reacted with rocket emoji
@tiangolotiangolo merged commit269a155 intofastapi:masterJun 13, 2020
@tiangolo
Copy link
Member

Perfect! Thanks for the opinion@phy25 ! 🙇

Thanks for the contribution@waynerv ! 🚀

@waynervwaynerv deleted the remove-duplicate-chinese-articles branchJune 14, 2020 00:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@phy25phy25phy25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@waynerv@tiangolo@phy25

[8]ページ先頭

©2009-2026 Movatter.jp