Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix the get_db example function#1293

Merged
tiangolo merged 1 commit intofastapi:masterfrom
bcb:fix-get_db
May 17, 2020
Merged

Fix the get_db example function#1293
tiangolo merged 1 commit intofastapi:masterfrom
bcb:fix-get_db

Conversation

@bcb
Copy link
Contributor

@bcbbcb commentedApr 20, 2020

Creation of the SessionLocal should be outside the try block.

@codecov
Copy link

codecovbot commentedApr 20, 2020
edited
Loading

Codecov Report

Merging#1293 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #1293   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          226       226             Lines         6785      6785           =========================================  Hits          6785      6785

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4e77737...c9af27c. Read thecomment docs.

@tiangolo
Copy link
Member

tiangolo commentedMay 17, 2020
edited
Loading

Hey@bcb , thanks for the suggestion.

Why do you think that it should be outside of the try block?

Edit: I just realized, thedb object should exist for thefinally section to use it even if everything inside exploded. Thanks!

bcb reacted with thumbs up emoji

@tiangolotiangolo merged commitd53a253 intofastapi:masterMay 17, 2020
@tiangolo
Copy link
Member

Great, thanks for your contribution@bcb ! 🚀 🍰

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bcb@tiangolo

Comments


[8]ページ先頭

©2009-2026 Movatter.jp