Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
Fix GZipMiddleware code block linking to TrustedHostMiddleware#1138
Conversation
codecovbot commentedMar 19, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1138 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 223 223 Lines 6642 6642 ========================================= Hits 6642 6642 Continue to review full report at Codecov.
|
bilencekic commentedMar 23, 2020
is it possible still wrong ? |
arimbr commentedMar 26, 2020
@bilencekic based on the content inhttps://github.com/tiangolo/fastapi/blob/master/fastapi/middleware/gzip.py which imports from @tiangolo Could you have a look at this. I've seen 4 other PR fixing the same issue ^^ |
bilencekic commentedMar 26, 2020
@arimbr yes correct it is working i am using like that but documentation has changed to |
arimbr commentedMar 26, 2020
Right! Thanks, It is just syntactic sugar introduced in#1064 where this issue was also introduced. |
f01fd73 tof274f71Comparetiangolo commentedMar 27, 2020
Great, thank you@arimbr ! 🔍 🕵️♂️ 🍰 🚀 And thanks for the discussion here everyone 👏 🍰 ☕ |
Inhttps://fastapi.tiangolo.com/advanced/middleware/#gzipmiddleware
BEFORE
AFTER