Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Fix GZipMiddleware code block linking to TrustedHostMiddleware#1138

Merged
tiangolo merged 1 commit intofastapi:masterfrom
arimbr:doc/fix-gzipmiddleware-code-block
Mar 27, 2020
Merged

Fix GZipMiddleware code block linking to TrustedHostMiddleware#1138
tiangolo merged 1 commit intofastapi:masterfrom
arimbr:doc/fix-gzipmiddleware-code-block

Conversation

@arimbr
Copy link
Contributor

dbanty and half2me reacted with heart emoji
@arimbrarimbr changed the titleFix GZipMiddleware code block linking to TrustedHostMiddleware[doc] Fix GZipMiddleware code block linking to TrustedHostMiddlewareMar 19, 2020
@codecov
Copy link

codecovbot commentedMar 19, 2020
edited
Loading

Codecov Report

Merging#1138 intomaster willnot change coverage by%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #1138   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          223       223             Lines         6642      6642           =========================================  Hits          6642      6642

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update670b643...f274f71. Read thecomment docs.

@bilencekic
Copy link

is it possible still wrong ?
should be starlette.middleware.gzip rather than fastapi.middleware.gzip

@arimbr
Copy link
ContributorAuthor

@bilencekic based on the content inhttps://github.com/tiangolo/fastapi/blob/master/fastapi/middleware/gzip.py which imports fromstarlette.middleware.gzip it should work right?

@tiangolo Could you have a look at this. I've seen 4 other PR fixing the same issue ^^

@bilencekic
Copy link

@arimbr yes correct it is working i am using like that but documentation has changed to
from fastapi.middleware.trustedhost import TrustedHostMiddleware
i think GZIP is also embedded to this middleware now.

@arimbr
Copy link
ContributorAuthor

Right! Thanks, It is just syntactic sugar introduced in#1064 where this issue was also introduced.

bilencekic reacted with thumbs up emoji

@tiangolotiangoloforce-pushed thedoc/fix-gzipmiddleware-code-block branch fromf01fd73 tof274f71CompareMarch 27, 2020 16:25
@tiangolotiangolo merged commit651ced6 intofastapi:masterMar 27, 2020
@tiangolo
Copy link
Member

Great, thank you@arimbr ! 🔍 🕵️‍♂️ 🍰 🚀

And thanks for the discussion here everyone 👏 🍰 ☕

arimbr reacted with heart emoji

@arimbrarimbr deleted the doc/fix-gzipmiddleware-code-block branchMarch 27, 2020 16:41
@tiangolotiangolo changed the title[doc] Fix GZipMiddleware code block linking to TrustedHostMiddlewareFix GZipMiddleware code block linking to TrustedHostMiddlewareFeb 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arimbr@bilencekic@tiangolo

[8]ページ先頭

©2009-2026 Movatter.jp