Fix exclude_unset and aliases in response model validation.#1074

Merged

tiangolo merged 2 commits intomasterfrom

unknown repository

Mar 27, 2020

Merged

Fix exclude_unset and aliases in response model validation.#1074
tiangolo merged 2 commits intomasterfrom
unknown repository

Conversation

Copy link

ghost commentedMar 3, 2020

Should fix both#1043 and#1063, but might come with some performance penalty since unnecessary serialization is being done. Better solutions that pass the given tests are more than welcome, but I don't see a much better way other than recursion in cases where there are models inside basic data structures like lists and dicts.

Copy link

codecovbot commentedMar 3, 2020•
edited
Loading

Codecov Report

Merging#1074 intomaster willnot change coverage by%.
The diff coverage is100.00%.

@@             Coverage Diff             @@##            master     #1074     +/-   ##===========================================  Coverage   100.00%   100.00%             ===========================================  Files          331       223    -108       Lines         8085      6642   -1443     ===========================================- Hits          8085      6642   -1443

Impacted Files	Coverage Δ
fastapi/routing.py	`100.00% <100.00%> (ø)`
tests/test_serialize_response_model.py	`100.00% <100.00%> (ø)`
docs/src/bigger_applications/app/routers/users.py
docs/src/custom_response/tutorial006.py
docs/src/sql_databases/sql_app/database.py
...cs/src/query_params_str_validations/tutorial012.py
...th_operation_advanced_configuration/tutorial001.py
docs/src/extra_models/tutorial005.py
docs/src/additional_responses/tutorial001.py
docs/src/extending_openapi/tutorial001.py
... and102 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update025b38d...1d2b874. Read thecomment docs.