Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

✨ Add support for Python 3.12#10666

Merged
alejsdev merged 3 commits intofastapi:masterfrom
Jamim:feature/python-3.12
Jan 10, 2024
Merged

✨ Add support for Python 3.12#10666
alejsdev merged 3 commits intofastapi:masterfrom
Jamim:feature/python-3.12

Conversation

@Jamim
Copy link
Contributor

Hello@tiangolo,

Thank you for this awesome framework! 🙇🏻‍♂️

I believe that it would be great to have an explicit Python 3.12 support, so I'd like to suggest changes that:

  • enable testing for Python 3.12 on CI
  • updateclassifiers atpyproject.toml
  • fix deprecation warning for tutorials

Best regards!

Tradunsky, stlucasgarcia, andreygaag, discdiver, dolfinus, manawasp, binbjz, IV1T3, Mazyod, and adaamz reacted with thumbs up emoji
@tiangolo
Copy link
Member

📝 Docs preview for commit6a803e9 at:https://fdeed641.fastapitiangolo.pages.dev

Jamim reacted with eyes emoji

@tiangolo
Copy link
Member

📝 Docs preview for commit9cf9b37 at:https://b363ac74.fastapitiangolo.pages.dev

Copy link
Contributor

@yezz123yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Amazing PR! We should have this ASAP In FastAPI 🚀

Jamim, iM-GeeKy, Gabiveu1574, crussell122, Tradunsky, stlucasgarcia, and SoyDiego reacted with heart emoji
@tiangolo
Copy link
Member

📝 Docs preview for commit4706a5a at:https://349a3a21.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

📝 Docs preview for commit726ad48 at:https://a5709203.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

📝 Docs preview for commit942720f at:https://29aa7fca.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

📝 Docs preview for commitbdfb1e6 at:https://3b25437a.fastapitiangolo.pages.dev

Copy link

@kiendangkiendang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My 2 cents: looks like FastAPI does not useutcnow in its library code (only indocs_src/security, notfastapi) so it should not provide a compat function for it. The fix should be in the tutorials, notfastapi/_compat.py

Jamim and DanielSarmiento04 reacted with thumbs up emojiJamim reacted with heart emoji
These changes:  * enable testing for Python 3.12 on CI  * update classifiers at pyproject.toml  * fix deprecation warning for tutorials
@tiangolo
Copy link
Member

📝 Docs preview for commitdb118d7 at:https://4c865de2.fastapitiangolo.pages.dev

@Jamim
Copy link
ContributorAuthor

Jamim commentedDec 27, 2023•
edited
Loading

Thank you for the review,@kiendang! 🙇🏻‍♂️

I've came to a conclusion that you are completely right, so I've updated the PR to get rid of an unnecessary compatibility function. Even better, I've realized there is a universal solution withdatetime.now(timezone.utc) that works for all supported Python versions.

kiendang reacted with heart emoji

@JamimJamim requested a review fromkiendangDecember 27, 2023 03:02
Copy link

@kiendangkiendang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🙌 Hopefully this got merged soon.

Jamim reacted with heart emoji
@Kludex
Copy link
Member

Kludex commentedDec 27, 2023•
edited
Loading

@tiangolo When you merge this, close the others:

Jamim, iM-GeeKy, stlucasgarcia, crussell122, Gabiveu1574, tiangolo, and binbjz reacted with thumbs up emojitiangolo and binbjz reacted with heart emoji

@Jamim
Copy link
ContributorAuthor

Hello@tiangolo,

Sorry for bothering you, but it would be really great if you find a few minutes for this PR.
It has already been refined based on community feedback and has received 3 approvals.

Thanks in advance and Happy New Year! 🎄

@alejsdevalejsdev changed the titleAdd support for Python 3.12✨ Add support for Python 3.12Jan 8, 2024
@alejsdevalejsdev added the featureNew feature or request labelJan 8, 2024
@tiangolo
Copy link
Member

Nice, thank you@Jamim! 🚀 🍰

And thanks for the reviews@kiendang,@yezz123, @lsglucas,@alejsdev 🙇

Jamim reacted with heart emojiyezz123 and stlucasgarcia reacted with rocket emoji

@tiangolotiangolo mentioned this pull requestJan 9, 2024
@tiangolo
Copy link
Member

📝 Docs preview for commit034ded2 at:https://56304ca1.fastapitiangolo.pages.dev

@alejsdevalejsdev merged commit07f8d31 intofastapi:masterJan 10, 2024
@JamimJamim deleted the feature/python-3.12 branchJanuary 10, 2024 22:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alejsdevalejsdevalejsdev approved these changes

+3 more reviewers

@kiendangkiendangkiendang approved these changes

@yezz123yezz123yezz123 approved these changes

@stlucasgarciastlucasgarciastlucasgarcia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

featureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Jamim@tiangolo@Kludex@kiendang@yezz123@stlucasgarcia@alejsdev
[8]ページ先頭
©2009-2026 Movatter.jp