Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
implemented chat feature using sidecar from starlette docs#1061
Merged
tiangolo merged 4 commits intofastapi:masterfromMar 27, 2020
aakashnand:chat_in_docs
Merged
implemented chat feature using sidecar from starlette docs#1061tiangolo merged 4 commits intofastapi:masterfromaakashnand:chat_in_docs
tiangolo merged 4 commits intofastapi:masterfrom
aakashnand:chat_in_docs
Conversation
codecovbot commentedMar 1, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1061 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 222 222 Lines 6569 6569 ========================================= Hits 6569 6569 Continue to review full report at Codecov.
|
Member
tiangolo commentedMar 27, 2020
Great! Thank you! 🍰 🚀 And thanks for taking the effort to take screenshots 👌 |
ContributorAuthor
aakashnand commentedFeb 24, 2024
@tiangolo Its Github's PR feature anniversary today. I checked my first PR usinghttps://firstpr.me/ and it turned out to be this PR. What an absolute pleasure to start my open-source journey with you@tiangolo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As@tiangolo mentioned in#1001. I thought of implementing chat in the documentation. This is my first PR for Fastapi and on github. Let me know if I miss something. I have tested locally and it is working fine. Below are some screenshots.