Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Added missing unit test dependencies to pyproject.toml#1026
Merged
tiangolo merged 1 commit intofastapi:masterfromFeb 29, 2020
Merged
Added missing unit test dependencies to pyproject.toml#1026tiangolo merged 1 commit intofastapi:masterfrom
tiangolo merged 1 commit intofastapi:masterfrom
Conversation
codecovbot commentedFeb 24, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1026 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 294 294 Lines 7732 7732 ========================================= Hits 7732 7732 Continue to review full report at Codecov.
|
Member
tiangolo commentedFeb 29, 2020
Yep, thanks for your contribution@sm-Fifteen ! 🚀 🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thecontribution instructions from the doc led to a number of unit tests failing on against a clean venv because of a few missing dependencies. I've read discussions regarding the possible removal of ujson (#820) and aiofiles (Kludex/starlette#480,Kludex/starlette#819) as dependencies, so I'm not entirely sure whether we're going to be keeping those in the future but, for the time being, their absence causes the test suite to fail.