Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Corrected missuse of a variable in the DRY exemple part of SOLID#77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
XalbatEcheverria wants to merge2 commits intothangchung:master
base:master
Choose a base branch
Loading
fromXalbatEcheverria:master

Conversation

@XalbatEcheverria
Copy link

Was using "employees" instead of "employee"

Copy link

@aroranirav2aroranirav2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, I would say it looks good to me.

Copy link
Contributor

@toanvo288toanvo288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Totally agree.

Copy link

@ChobocharlesChobocharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

4 more reviewers

@aroranirav2aroranirav2aroranirav2 left review comments

@ChobocharlesChobocharlesChobocharles approved these changes

@toanvo288toanvo288toanvo288 approved these changes

@dmitryvhfdmitryvhfdmitryvhf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XalbatEcheverria@aroranirav2@Chobocharles@toanvo288@dmitryvhf

[8]ページ先頭

©2009-2025 Movatter.jp