NotificationsYou must be signed in to change notification settings
Fork1k
Star2k

Commitadb5ca2

enztngh

committed

GITHUB-3196: support to execlude somes 'test' in option of command line

1 parente8b8bf3 commitadb5ca2Copy full SHA for adb5ca2

File tree

3 files changed

+15

-12

lines changed

README.md
testng-core-api/src/main/java/org/testng/xml
- XmlTest.java
testng-core/src/main/java/org/testng/xml/internal
- TestNamesMatcher.java

3 files changed

+15

-12

lines changed

`‎README.md`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`[![Sonarqube Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=org.testng%3Atestng&metric=alert_status)](https://sonarcloud.io/dashboard?id=org.testng%3Atestng)`
`5`	`5`
`6`	`6`	`Documentation available at[TestNG's main web site](https://testng.org). Visit[TestNG Documentation's GitHub Repo](https://github.com/testng-team/testng-team.github.io) to contribute to it.`
	`7`	`+`
`7`	`8`	`###Release Notes`
`8`	`9`	`*[7.10.0](https://groups.google.com/g/testng-users/c/6DmFaKUjIxY)`
`9`	`10`	`*[7.9.0](https://groups.google.com/g/testng-users/c/nN7LkuZWO48)`
`@@ -39,7 +40,7 @@ Always make sure your issue is happening on the latest TestNG version. Bug repor`
`39`	`40`
`40`	`41`	`###Have you considered sending a pull request instead of filing an issue?`
`41`	`42`	`The best way to report a bug is to provide the TestNG team with a full test case reproducing the issue.`
`42`		-Maybe you can write a runnable test case (check the`src/test/` folder for examples) and propose it in a pull request
	`43`	+Maybe you can write a runnable test case (check the`src/test/` folder for examples) and propose it in a pull request
`43`	`44`	`Don't worry if the CI fails because it is the expected behavior.`
`44`	`45`	`This pull request will be a perfect start to find the fix :)`
`45`	`46`
`@@ -48,12 +49,12 @@ Refer our [Contributing](.github/CONTRIBUTING.md) section for detailed set of st`
`48`	`49`
`49`	`50`	`###We encourage pull requests that:`
`50`	`51`
`51`		`-* Add new features to TestNG (or)`
`52`		`-* Fix bugs in TestNG`
	`52`	`+* Add new features to TestNG (or)`
	`53`	`+* Fix bugs in TestNG`
	`54`	`+`
	`55`	`+If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the`
	`56`	`+[TestNG-dev](https://groups.google.com/forum/#!forum/testng-dev) before you spend time working on it.`
`53`	`57`
`54`		`- If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the`
`55`		`-[TestNG-dev](https://groups.google.com/forum/#!forum/testng-dev) before you spend time working on it.`
`56`		`-`
`57`	`58`	`###GPG Keys`
`58`	`59`
`59`	`60`	`####Getting the keys`

`‎testng-core-api/src/main/java/org/testng/xml/XmlTest.java`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -625,6 +625,6 @@ public XmlGroups getXmlGroups() {`
`625`	`625`	`* @return <code>true</code> if the current test's name matches with any of the given names.`
`626`	`626`	`*/`
`627`	`627`	`publicbooleannameMatchesAny(List<String>names) {`
`628`		`-returnnames.stream().allMatch(regex ->Pattern.matches(regex,getName()));`
	`628`	`+returnnames.stream().anyMatch(regex ->Pattern.matches(regex,getName()));`
`629`	`629`	`}`
`630`	`630`	`}`

`‎testng-core/src/main/java/org/testng/xml/internal/TestNamesMatcher.java`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`packageorg.testng.xml.internal;`
`2`	`2`
`3`	`3`	`importjava.util.List;`
	`4`	`+importjava.util.regex.Pattern;`
`4`	`5`	`importorg.testng.TestNGException;`
`5`	`6`	`importorg.testng.collections.Lists;`
`6`	`7`	`importorg.testng.log4testng.Logger;`
`@@ -21,8 +22,6 @@ public final class TestNamesMatcher {`
`21`	`22`	`privatefinalList<XmlSuite>cloneSuites =Lists.newArrayList();`
`22`	`23`	`privatefinalList<String>matchedTestNames =Lists.newArrayList();`
`23`	`24`	`privatefinalList<XmlTest>matchedTests =Lists.newArrayList();`
`24`		`-privatefinalList<String>missedTestNames =Lists.newArrayList();`
`25`		`-privatefinalList<XmlTest>missedTests =Lists.newArrayList();`
`26`	`25`	`privatefinalList<String>testNames;`
`27`	`26`	`privatefinalbooleanignoreMissedTestNames;`
`28`	`27`
`@@ -89,6 +88,12 @@ public boolean validateMissMatchedTestNames() {`
`89`	`88`	`}`
`90`	`89`
`91`	`90`	`publicList<String>getMissedTestNames() {`
	`91`	`+List<String>missedTestNames =Lists.newArrayList();`
	`92`	`+missedTestNames.addAll(testNames);`
	`93`	`+missedTestNames.removeIf(regex ->`
	`94`	`+matchedTestNames.stream()`
	`95`	`+ .anyMatch(testName ->Pattern.matches(regex,testName))`
	`96`	`+ );`
`92`	`97`	`returnmissedTestNames;`
`93`	`98`	`}`
`94`	`99`
`@@ -109,9 +114,6 @@ private XmlSuite cloneIfSuiteContainTestsWithNamesMatchingAny(XmlSuite suite) {`
`109`	`114`	`tests.add(xt);`
`110`	`115`	`matchedTestNames.add(xt.getName());`
`111`	`116`	`matchedTests.add(xt);`
`112`		`- }else {`
`113`		`-missedTestNames.add(xt.getName());`
`114`		`-missedTests.add(xt);`
`115`	`117`	`}`
`116`	`118`	`}`
`117`	`119`	`if (tests.isEmpty()) {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitadb5ca2

File tree

3 files changed

3 files changed

`‎README.md`

`‎testng-core-api/src/main/java/org/testng/xml/XmlTest.java`

`‎testng-core/src/main/java/org/testng/xml/internal/TestNamesMatcher.java`

0 commit comments