- Notifications
You must be signed in to change notification settings - Fork232
feat(waitFor): Automatically advance Jest fake timers#878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
eps1lon wants to merge1 commit intotesting-library:mainChoose a base branch fromeps1lon:feat/waitfor-jest-fake-timers
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
netlifybot commentedJul 19, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
❌ Deploy Preview forreact-hooks-testing-library failed.
|
30e6f0f
to18bfadf
Compareeps1lon commentedAug 26, 2022
// to resolve before continuing. We don't need to take advantage | ||
// of parallelization so we're fine. | ||
// https://stackoverflow.com/a/59243586/971592 | ||
await act(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is useless for React 17 and should be removed to not confuse. It is only needed in 18 where we need to remove theact
fromwaitFor
SimenB commentedNov 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What:
Closes#873
Why:
There's little value in
waitFor
if one has to advance timers by themselves.How:
Copy implementation from
@testing-library/dom
.There's an opportunity to write a more generic
waitFor
that we can share across Testing Library that specific host configs build on top on (e.g. also running MutationObserver in/dom
). But that requires more coordination (starting with an extensive test suite). For now this hopefully suffices (pending testing in actual codebases).Checklist: