Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Output the Service Attachment links for Replicas#758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
imrannayer merged 5 commits intoterraform-google-modules:mainfromyasra002:patch-1
Aug 15, 2025

Conversation

@yasra002
Copy link
Contributor

@yasra002yasra002 commentedAug 7, 2025•
edited
Loading

Add service attachment outputs for Postgres replicas

fixes :#762

Google's Terraform module for Postgres does not currently expose service attachment outputs for replicas,.This PR adds outputs for the service attachments of Postgres replicas in the Google Cloud SQL Terraform module.
The module already exposes the service attachment for the primary instance, but not for any replicas. This fills that gap so we can reference replica attachments just like the primary.

@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yasra002yasra002 changed the titleOutput the Service Attachment links for Replicasfix: Output the Service Attachment links for ReplicasAug 12, 2025
@imrannayer
Copy link
Collaborator

@yasra002 thanks for the PR. can u plz fix lint issues. Follow this guid
https://github.com/terraform-google-modules/terraform-google-sql-db/blob/main/CONTRIBUTING.md

@imrannayerimrannayer added the waiting-responseWaiting for issue author to respond. labelAug 13, 2025
@yasra002
Copy link
ContributorAuthor

yasra002 commentedAug 14, 2025•
edited
Loading

@imrannayer Thanks for the reply. I have now fixed the linting issue.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayerimrannayer changed the titlefix: Output the Service Attachment links for Replicasfeat: Output the Service Attachment links for ReplicasAug 15, 2025
@imrannayerimrannayer removed the waiting-responseWaiting for issue author to respond. labelAug 15, 2025
@imrannayerimrannayer merged commite5446b7 intoterraform-google-modules:mainAug 15, 2025
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@imrannayerimrannayerimrannayer approved these changes

@ayushmjainayushmjainAwaiting requested review from ayushmjainayushmjain is a code owner

@q2wq2wAwaiting requested review from q2wq2w is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing PSC attachment output for read replicas in PostgreSQL module

2 participants

@yasra002@imrannayer
[8]ページ先頭
©2009-2025 Movatter.jp