Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Support retain_backups_on_delete for postgres#737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
imrannayer merged 2 commits intoterraform-google-modules:mainfromb-n:main
Jun 18, 2025

Conversation

@b-n
Copy link
Contributor

@b-nb-n commentedJun 11, 2025•
edited
Loading

Inspiration (e.g. direct copy/paste) from the work of@OscarVanL on#735

I tried to useCo-authored-by on the commit, however the CLA check did not recognize Oscar, even thought I used the exact username/email combination that exists in other commits. Either way, thanks@OscarVanL !

This would be nice for us since we're using the postgres module for some of our databases in Instruqt.

Relates:#735

Tests

  • make generate_docs

OscarVanL and jokersoft reacted with thumbs up emoji
@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Adding Oscar as co-author since this is direct copy/paste from theirmysql changesInspiration from: Oscar van Leusen <oscar.vanleusen@pexip.com> (Couldnot add as co-authored-by due to Google CLA not agreeing for some weirdreason)
@OscarVanL
Copy link
Contributor

LGTM (but also I am not a Googler, so that doesn't mean that much)

b-n reacted with heart emoji

@imrannayer
Copy link
Collaborator

gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayerimrannayer merged commiteb9b52f intoterraform-google-modules:mainJun 18, 2025
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@imrannayerimrannayerimrannayer approved these changes

@ayushmjainayushmjainAwaiting requested review from ayushmjainayushmjain is a code owner

@q2wq2wAwaiting requested review from q2wq2w is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@b-n@OscarVanL@imrannayer
[8]ページ先頭
©2009-2025 Movatter.jp