Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: adds var.enable_privately_used_public_ips to create_environment_v2#129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fernandoiury
Copy link
Contributor

@fernandoiuryfernandoiury commentedMar 20, 2024•
edited
Loading

adds var.enable_privately_used_public_ips to create_environment_v2 allowing public (non-RFC1918) ranges to be used.

closes#128

@imrannayer
Copy link
Collaborator

@fernandoiury thx for the PR. Can you plz change variable description

fernandoiury reacted with thumbs up emoji

@fernandoiury
Copy link
ContributorAuthor

@fernandoiury thx for the PR. Can you plz change variable description

Thx for the quick response. Done.

@imrannayer
Copy link
Collaborator

@fernandoiury can u plz followthis to generate doc to fix lint issue?
Thanks

fernandoiury reacted with thumbs up emoji

@fernandoiury
Copy link
ContributorAuthor

fernandoiury commentedMar 21, 2024•
edited
Loading

@fernandoiury can u plz followthis to generate doc to fix lint issue? Thanks

ahhaha I tried to fix it before using the github app on my phone... Now it's properly done using docker.
sorry@imrannayer :)

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayerimrannayer self-requested a reviewMarch 21, 2024 17:50
@imrannayerimrannayer merged commit47884d5 intoterraform-google-modules:masterMar 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@imrannayerimrannayerimrannayer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Composer v2 is missing enable_privately_used_public_ips in private_environment_config

2 participants

@fernandoiury@imrannayer
[8]ページ先頭
©2009-2025 Movatter.jp