Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork278
feat: Add support for CloudFront Standard Logging#187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
clark42 wants to merge2 commits intoterraform-aws-modules:masterChoose a base branch fromKamorionLabs:feature/logging-v2
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+232 −30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add support for CloudFront Standard Logging using CloudWatch Log Delivery resources.This replaces the legacy logging_config and allows logging to S3, CloudWatch Logs,or Firehose as destinations.Standard logging is automatically enabled when std_logging_destination orstd_logging_destination_arn is provided (no separate enable flag needed).New variables:- std_logging_region: region for logging resources (default: us-east-1)- std_logging_source_name: optional custom name for delivery source- std_logging_destination_arn: use existing destination (skip creation)- std_logging_destination: destination configuration (name, output_format, destination_arn)- std_logging_delivery: delivery configuration (field_delimiter, record_fields, s3_delivery_configuration)New outputs:- cloudfront_std_logging_source_arn- cloudfront_std_logging_source_name- cloudfront_std_logging_destination_arn- cloudfront_std_logging_delivery_id- cloudfront_std_logging_delivery_arn
…types- Remove dedicated tags from logging variables, use var.tags instead- Add delivery_destination_type parameter for X-Ray trace delivery support- Make destination_arn optional (not required for X-Ray)- Make delivery_destination_configuration a dynamic block
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for CloudFront Standard Logging using CloudWatch Log Delivery resources. This replaces the legacy logging_config and allows logging to S3, CloudWatch Logs, or Firehose as destinations.
Standard logging is automatically enabled when std_logging_destination or std_logging_destination_arn is provided (no separate enable flag needed).
New variables:
New outputs:
Motivation and Context
AWS announced CloudFront Standard Logging in November 2024, providing significant improvements over legacy logging:
Related:
Breaking Changes
No breaking changes. This is an additive feature. Existing logging_config (legacy logging) continues to work unchanged.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request