Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Addupdate_variant_statuses() and unit tests#5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
amishler wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromalan/add-variant-status-update-function

Conversation

@amishler
Copy link
Member

@amishleramishler commentedDec 18, 2025•
edited
Loading

  • Add a pure function that will be used in the top-k variant selection loop.
  • This function will run at the end of a batch of evals to decide for each variant whether evaluation can stop for one of the following reasons: because it's guaranteed to be included in the top-k set, because it's guaranteed to be excluded from the top-k set, or because it has had too many inference failures.
  • There are temporary#[cfg(test)] tags that will be removed once additional functions are written that call this function.

@amishleramishler changed the titleAddupdate_variant_status() and unit testsAddupdate_variant_statuses() and unit testsDec 18, 2025
@amishler
Copy link
MemberAuthor

@codex review

Copy link

@chatgpt-codex-connectorchatgpt-codex-connectorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

@virajmehtavirajmehtavirajmehta approved these changes

Assignees

@virajmehtavirajmehta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amishler@virajmehta
[8]ページ先頭
©2009-2025 Movatter.jp