- Notifications
You must be signed in to change notification settings - Fork746
[Stacked] Migrate getCumulativeFeedbackTimeseries#5269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
shuyangli wants to merge3 commits intomainChoose a base branch fromsl/migrate-feedback-queries-to-gateway
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+1,512 −377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
733c66f to3ed370dCompare4a3c442 to2f91657Compared01f70b to96bb612Compare2f91657 toc604a6dCompare…window filteringRefactors the time-based filtering in ClickHouse inference stats queries:- Changed time_window_to_ms to time_window_to_duration returning std::time::Duration- Use ClickHouse's UUIDv7ToDateTime function for timestamp comparison instead of manual bit manipulation of UUIDv7 format- Pass time delta in seconds to ClickHouse, use INTERVAL SECOND for arithmetic- Preserves original semantics of filtering relative to max timestamp in the dataFix inference stats e2e test assertions- Check RFC 3339 format with milliseconds on raw HTTP response body instead of re-serializing DateTime (chrono's default serializer omits .000 for zero ms)- Relax variant count assertion from 2+ to 1+ for fixture data flexibility
c604a6d tocc51a91Compare- Add new route handler for /internal/feedback/timeseries- Add unit tests using mock ClickHouse- Add e2e tests for the new endpoint- Add e2e ClickHouse tests for getCumulativeFeedbackTimeseries- Add getCumulativeFeedbackTimeseries method to TensorZeroClient- Update function route to use TensorZeroClient instead of DatabaseClient for cumulative feedback- Remove getCumulativeFeedbackTimeseries from tensorzero-node NAPI bindings
96bb612 toe7b18feCompare341c0a8 toc329576Compare32e9aee toe538951Compare Base automatically changed fromsl/migrate-get-function-throughput-by-variant tomainDecember 19, 2025 01:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Also delete getFeedbackByVariant since it's unused.