- Notifications
You must be signed in to change notification settings - Fork746
Run all migrations in#[sqlx] tests#5256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Aaron1011 wants to merge3 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+130 −40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
We now use 'manual_run_postgres_migrations_with_url' at the startof each test, since we have non-trivial dependencies betweenthe migrations in our various crates
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR updates all#[sqlx::test] tests to manually run PostgreSQL migrations at the start of each test, addressing non-trivial dependencies between migrations across multiple crates.
Key Changes:
- Extracted a new
manual_run_postgres_migrations_with_urlfunction that accepts a database URL parameter - Updated all test functions to accept
PgPoolOptionsandPgConnectOptionsparameters instead of a pre-configured pool - Each test now explicitly runs migrations before creating its connection pool
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tensorzero-core/src/db/postgres/mod.rs | Addedmanual_run_postgres_migrations_with_url function that accepts a URL parameter and refactored the existing function to use it |
tensorzero-core/tests/e2e/db/rate_limit_queries.rs | Updated 11 test functions to use the new manual migration pattern with explicit pool creation |
tensorzero-core/tests/e2e/db/experimentation_queries.rs | Updated 6 test functions to use the new manual migration pattern with explicit pool creation |
virajmehta previously approved these changesDec 17, 2025
virajmehta approved these changesDec 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
We now use 'manual_run_postgres_migrations_with_url' at the start of each test, since we have non-trivial dependencies between the migrations in our various crates
Important
Run all migrations in SQLx tests using
manual_run_postgres_migrations_with_urlfor consistent database state.manual_run_postgres_migrations_with_urlat the start of each test inexperimentation_queries.rsandrate_limit_queries.rsto ensure all migrations are run.migrationsattribute from#[sqlx::test]macro inexperimentation_queries.rsandrate_limit_queries.rs.manual_run_postgres_migrations_with_urlinmod.rsto run migrations using a provided URL.manual_run_postgres_migrationsinmod.rsto callmanual_run_postgres_migrations_with_url.experimentation_queries.rsandrate_limit_queries.rsto usemanual_run_postgres_migrations_with_urlfor migration setup.This description was created by
for3e1ff7f. You cancustomize this summary. It will automatically update as commits are pushed.