- Notifications
You must be signed in to change notification settings - Fork746
Add DatasetCombobox and DatasetSelect#5208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
simeonlee wants to merge17 commits intosimeonlee/function-selector-comboboxChoose a base branch
base:simeonlee/function-selector-combobox
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Add DatasetCombobox and DatasetSelect#5208
simeonlee wants to merge17 commits intosimeonlee/function-selector-comboboxfromsimeonlee/dataset-selector-combobox
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…onSelector- Create DatasetComboboxSelector for input-style dataset selection- Rename DatasetSelector to DatasetButtonSelector for button-style selection- Add ComboboxContent and ComboboxHint components- Update imports across codebase to use appropriate selector variant- DatasetComboboxSelector used in: LaunchEvaluationModal, playground, NewDatapointForm- DatasetButtonSelector used in: CloneDatapointButton, AddToDatasetButton, evaluation page
- Extract useDatasetSelector hook for shared data fetching and helpers- Extract ComboboxMenuItems for shared menu rendering- Add count pill to DatasetButtonSelector selected state- Update Combobox to use ComboboxMenuItems internally- Update e2e tests for new placeholder text
…elector with variant prop
- Add DatasetCombobox for input-as-trigger pattern- Add DatasetSelect for button-as-trigger pattern- Add shared use-dataset-options hook for data fetching and filtering- Add searchPlaceholder for DatasetSelect CommandInput- Add default styles to CommandEmpty (text-fg-tertiary)- Update test placeholders to match new text
e248cba to17a84abCompare- Simplify DatasetCombobox to use Combobox directly (~146 to ~53 lines)- Rename getItemIcon/getItemSuffix to getPrefix/getSuffix- Fix create icon showing when allowCreation is false- Fix creationHint/createHeading only passed when allowCreation is true- Remove default allowCreation=true from DatasetFormField- Export items from useDatasetOptions hook- Unify suffix styling as styled pill elements
CollaboratorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In the future, this will also reuse a standard Select
- Extract shared fixtures to dataset-stories-fixtures.ts- Add Disabled story to both components- Add TODO for virtualization on large lists- Rename creationHint to createHint for consistency
Uh oh!
There was an error while loading.Please reload this page.
| }, | ||
| }; | ||
| // TODO: we should handle extremely long lists (1000+) of datasets gracefully (e.g. virtualization) |
CollaboratorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This TODO comment was pre-existing (but noted)
virajmehta approved these changesDec 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Splits the monolithic
DatasetSelectorinto two specialized components:ComboboxcomponentBoth share data fetching and filtering logic via
useDatasetOptionshook.This addresses consistency issues with the other comboboxes implemented as part of#4804 as well as closes the loop on some dataset selector updates as part of#1236. From conversation with@GabrielBianconi we decided to keep the button-style selector as-is but upgrade the combobox creation flow for a consistent creation pattern with our model selector combobox work from last week.
Test plan
Important
Introduce
DatasetComboboxandDatasetSelectcomponents to replaceDatasetSelector, with shared logic and updated tests and stories.DatasetComboboxfor input-style selection in forms, usingComboboxcomponent.DatasetSelectfor button-style selection for inline actions.useDatasetOptionshook.DatasetSelectorwithDatasetComboboxinNewDatapointForm.tsxandDatasetBuilderForm.tsx.DatasetSelectorwithDatasetSelectinCloneDatapointButton.tsxandAddToDatasetButton.tsx.DatasetCombobox.stories.tsxforDatasetCombobox.DatasetSelector.stories.tsxtoDatasetSelect.stories.tsxand update forDatasetSelect.dataset-stories-fixtures.tsfor mock dataset data.formatCompactNumberinchart.tsfor number formatting.This description was created by
for5595577. You cancustomize this summary. It will automatically update as commits are pushed.