Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Infer result type from result_type arg under string name overload#938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dandavison wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromworkflow-infer-type-from-result-type-arg

Conversation

@dandavison
Copy link
Contributor

image

@dandavisondandavison requested a review froma team as acode ownerJuly 3, 2025 01:30
@dandavisondandavisonforce-pushed theworkflow-infer-type-from-result-type-arg branch fromb173c7f toc665665CompareJuly 3, 2025 01:32
Copy link
Member

@cretzcretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should this also be done withworkflow things likeexecute_activity,start_activity,execute_child_workflow, andstart_child_workflow?

@dandavisondandavisonforce-pushed theworkflow-infer-type-from-result-type-arg branch fromc665665 toba0303aCompareJuly 4, 2025 00:46
@dandavisondandavisonforce-pushed theworkflow-infer-type-from-result-type-arg branch fromba0303a to1097275CompareAugust 19, 2025 13:26
@dandavison
Copy link
ContributorAuthor

Should this also be done withworkflow things likeexecute_activity,start_activity,execute_child_workflow, andstart_child_workflow?

Yes, opened#1077 to investigate.

@dandavison
Copy link
ContributorAuthor

The reason this PR hasn't been merged is that it seems to cause mypy to demand type annotations on the LHS of assignments. See6b0fe3eb9b45ee4eeca8cf8a62855f8e2ece10a1q

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cretzcretzcretz approved these changes

@tconley1428tconley1428tconley1428 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dandavison@cretz@tconley1428
[8]ページ先頭
©2009-2025 Movatter.jp