Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature/adds activities providers#759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
spacether wants to merge2 commits intotemporalio:main
base:main
Choose a base branch
Loading
fromspacether:feature/adds-activties-providers

Conversation

@spacether
Copy link

@spacetherspacether commentedFeb 2, 2025
edited
Loading

What was changed

  • I added two methods (ActivitiesProvider.get_activities_from_instance +ActivitiesProvider.get_activities_from_cls) to get activities from classes that inherit from ActivitiesProvider
  • I added the functionget_activities to get activities from a python module
  • tests are added of the two new methods and the 1 new function

Why?

These are useful to my code base to extract activities from classes and module

Checklist

  1. Closes[Feature Request] Suggest Providing activities extraction utilities to get them from a class and a module #758

  2. How was this tested:

  • I added tests of the new functionality; they all pass
  1. Any docs updates needed?
    Yes, not sure where docs are generated from, where should this be added?

@spacetherspacether requested a review froma team as acode ownerFebruary 2, 2025 22:58
@CLAassistant
Copy link

CLAassistant commentedFeb 2, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

Copy link
Member

@cretzcretzFeb 3, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hrmm, I think many users that need activity discovery are using their own decorators and capturing in a big list/dict. If we want to make activity discovery more explicit, we should also consider providing other definition information such as the name, whether they have disabled thread-raise on cancel, etc.

Also, many people use different activities in different workers in the same process, so not sure it makes sense to have a "provider" API as if there is only one worker and all activities will belong to it. Users need to individually choose which activities to give to which workers.

I could see maybe exposing the activity definition and could see maybe exposing a way to get all known definitions that provide a@activity.defn decorator, but in general different users combine/collect activities in different ways and I'm not sure we want a "blessed" one.

Copy link
Author

@spacetherspacetherFeb 3, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It covers my use cases and I am only one user. Is there any way that we can ask devs and get numbers from the community on if they want this MR or something like it?

Also not suggesting that this will work for all users, only some.

Copy link
Member

@cretzcretzFeb 3, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately with our open source nature it is hard to gauge interest unless it is something that is a pain point for users. I do think we could consider exposing all activity definitions in a static/global way, though that's not the same thing as a list you may want to map to callables and then pass into a worker. We have not done this traditionally in any other SDK, instead relying on users to collect their activities in their preferred way (though we have integrated with things like Sprint Boot in Java).

Copy link
Author

@spacetherspacetherFeb 3, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You have a Slack temporal community with +7,500 members in the #python-sdk, channel, may I ask them there?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cretzcretzcretz left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Suggest Providing activities extraction utilities to get them from a class and a module

3 participants

@spacether@CLAassistant@cretz

[8]ページ先頭

©2009-2025 Movatter.jp