Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(converter): handle serialization of recursive exceptions#696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
yunmanger1 wants to merge1 commit intotemporalio:main
base:main
Choose a base branch
Loading
fromyunmanger1:fix-recursive-error-serialization

Conversation

@yunmanger1
Copy link

Handle edge case of recursive exceptions in failure converter.

Why?

It is kind of an easy mistake to do in python:

try:    raise ValueError("test")except Exception as e:    raise e from e

The re-raised exception will havee.__cause__ referencing itself resulting in failure to serialize error and python sdk won't report anything resulting in retries and startToClose timeouts.

@yunmanger1yunmanger1 requested a review froma team as acode ownerDecember 3, 2024 21:39
@CLAassistant
Copy link

CLAassistant commentedDec 3, 2024
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yunmanger1yunmanger1force-pushed thefix-recursive-error-serialization branch from4e4f84a to1ec3f62CompareDecember 3, 2024 21:43
It is kind of an easy mistake to do in python:```try:    raise ValueError("test")except Exception as e:    raise e from e```The reraised exception will have e.__cause__ referencing itself resulting in failure to serialize error and python sdk won't report anything resulting in retries and startToClose timeouts.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yunmanger1@CLAassistant

[8]ページ先頭

©2009-2025 Movatter.jp