- Notifications
You must be signed in to change notification settings - Fork143
fix(converter): handle serialization of recursive exceptions#696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
yunmanger1 wants to merge1 commit intotemporalio:mainChoose a base branch fromyunmanger1:fix-recursive-error-serialization
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
fix(converter): handle serialization of recursive exceptions#696
yunmanger1 wants to merge1 commit intotemporalio:mainfromyunmanger1:fix-recursive-error-serialization
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CLAassistant commentedDec 3, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
4e4f84a to1ec3f62CompareIt is kind of an easy mistake to do in python:```try: raise ValueError("test")except Exception as e: raise e from e```The reraised exception will have e.__cause__ referencing itself resulting in failure to serialize error and python sdk won't report anything resulting in retries and startToClose timeouts.1ec3f62 tof1dd820CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle edge case of recursive exceptions in failure converter.
Why?
It is kind of an easy mistake to do in python:
The re-raised exception will have
e.__cause__referencing itself resulting in failure to serialize error and python sdk won't report anything resulting in retries and startToClose timeouts.