- Notifications
You must be signed in to change notification settings - Fork94
Example with new plugin PR#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| set_open_ai_agent_temporal_overrides, | ||
| ) | ||
| fromtemporalio.contrib.openai_agentsimportPlugin | ||
| fromtemporalio.contrib.pydanticimportpydantic_data_converter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This import not needed anymore either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[I like using a ruff IDE extension and setting format-on-save to true.]
| client=awaitClient.connect( | ||
| "localhost:7233", | ||
| data_converter=open_ai_data_converter, | ||
| plugins=[Plugin()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we probably want to encourage plugin authors to name this object likeOpenAIAgentsPlugin so that even if imported usingfrom ... import ... it's still clear at the usage site what plugin it is.
Alternatively we could reference it asopenai_agents.Plugin, but I think encouraging the fully-qualified plugin object name makes sense.
| set_open_ai_agent_temporal_overrides, | ||
| ) | ||
| fromtemporalio.contrib.openai_agentsimportPlugin | ||
| fromtemporalio.contrib.pydanticimportpydantic_data_converter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[I like using a ruff IDE extension and setting format-on-save to true.]
What was changed
Why?
Checklist
Closes
How was this tested: