- Notifications
You must be signed in to change notification settings - Fork94
Properly skip infrequent polling test on time-skipping server#186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| asyncdeftest_infrequent_polling_workflow(client:Client,env:WorkflowEnvironment): | ||
| ifnotenv.supports_time_skipping: | ||
| ifenv.supports_time_skipping: | ||
| pytest.skip("Too slow to test with time-skipping disabled") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The boolean condition and the message don't seem to jointly make sense any longer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hrmm, maybe I misunderstood the situation here and we are wanting to only run this test with time skipping and it's still too slow even with time skipping. Will look.
What was changed
Properly skip infrequent polling test on time-skipping server
Checklist