Commit45a36d3

cclauss

authored and

trekhleb

committed

Travis CI: Add flake8 to the testing (trekhleb#5)

* Travis CI: Add flake8 to the testing Add [flake8](http://flake8.pycqa.org) tests to find Python syntax errors and undefined names.__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.* F821: undefined name `name`* F822: undefined name `name` in `__all__`* F823: local variable name referenced before assignment* E901: SyntaxError or IndentationError* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree* learn-python should not teach the antipattern of bare exceptionsSee PEP8 andhttps://realpython.com/the-most-diabolical-python-antipattern* noqa F821 - We are intentionally raising NameError* Two consecutive blank lines before a function definition* flake8 --max-complexity=10 --> 12* pylint: disable=broad-except

1 parent72f2e5c commit45a36d3Copy full SHA for 45a36d3

File tree

4 files changed

+11

-3

lines changed

.travis.yml
src
- control_flow
  - test_try.py
- data_types
  - test_lists.py
- modules
  - test_modules.py

4 files changed

+11

-3

lines changed

`‎.travis.yml‎`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,14 @@ python:`
`5`	`5`	`# Install dependencies.`
`6`	`6`	`install:`
`7`	`7`	`-pip install -r requirements.txt`
	`8`	`+ -pip install flake8`
`8`	`9`
`9`	`10`	`# Run linting and tests.`
`10`	`11`	`script:`
	`12`	`+# stop the build if there are Python syntax errors or undefined names`
	`13`	`+ -flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics`
	`14`	`+# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide`
	`15`	`+ -flake8 . --count --exit-zero --max-complexity=12 --max-line-length=127 --statistics`
`11`	`16`	`-pylint ./src`
`12`	`17`	`-pytest`
`13`	`18`

`‎src/control_flow/test_try.py‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ def test_try():`
`18`	`18`
`19`	`19`	`# The try block will generate an error, because x is not defined:`
`20`	`20`	`exception_has_been_caught=False`
	`21`	`+`
`21`	`22`	`try:`
`22`	`23`	`# pylint: disable=undefined-variable`
`23`	`24`	`print(not_existing_variable)`
`@@ -41,6 +42,7 @@ def test_try():`
`41`	`42`	`# You can use the else keyword to define a block of code to be executed`
`42`	`43`	`# if no errors were raised.`
`43`	`44`	`message=''`
	`45`	`+# pylint: disable=broad-except`
`44`	`46`	`try:`
`45`	`47`	`message+='Success.'`
`46`	`48`	`exceptNameError:`
`@@ -54,8 +56,8 @@ def test_try():`
`54`	`56`	`# error or not.`
`55`	`57`	`message=''`
`56`	`58`	`try:`
`57`		`-# pylint:disable=undefined-variable`
`58`		`-print(not_existing_variable)`
	`59`	`+# pylint: undefined-variable`
	`60`	`+print(not_existing_variable)# noqa: F821`
`59`	`61`	`exceptNameError:`
`60`	`62`	`message+='Something went wrong.'`
`61`	`63`	`finally:`

`‎src/data_types/test_lists.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ def test_del_statement():`
`195`	`195`	`withpytest.raises(Exception):`
`196`	`196`	`# Referencing the name a hereafter is an error (at least until another`
`197`	`197`	`# value is assigned to it).`
`198`		`-assertnumbers== []`
	`198`	`+assertnumbers== []# noqa: F821`
`199`	`199`
`200`	`200`
`201`	`201`	`deftest_list_comprehensions():`

`‎src/modules/test_modules.py‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@`
`39`	`39`	`# It can also be used when utilising from with similar effects:`
`40`	`40`	`fromfibonacci_moduleimportfibonacci_at_positionasfibonacci_at_position_renamed`
`41`	`41`
	`42`	`+`
`42`	`43`	`# When a module named spam is imported, the interpreter first searches for a built-in module with`
`43`	`44`	`# that name. If not found, it then searches for a file named spam.py in a list of directories`
`44`	`45`	`# given by the variable sys.path. sys.path is initialized from these locations:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit45a36d3

File tree

4 files changed

4 files changed

`‎.travis.yml‎`

`‎src/control_flow/test_try.py‎`

`‎src/data_types/test_lists.py‎`

`‎src/modules/test_modules.py‎`

0 commit comments