- Notifications
You must be signed in to change notification settings - Fork53
Introduce test for interface fragment on object type#261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Kingdutch wants to merge1 commit intoteamwalnut:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Introduce test for interface fragment on object type#261
Kingdutch wants to merge1 commit intoteamwalnut:masterfromKingdutch:bugreport/interface-fragment-on-object
+50 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If interface A is implemented by object B then a fragment F on A should bespreadable on a field returning object B. This is described in the specunder [section5.5.2.3.1](https://spec.graphql.org/June2018/#sec-Abstract-Spreads-in-Object-Scope).
Contributor
jfrolich commentedJul 2, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks! I think I made it too type-safe so this case raises an error. I'll look into how this can be addressed. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If interface A is implemented by object B then a fragment F on A should be
spreadable on a field returning object B. This is described in the spec
undersection
5.5.2.3.1.
This test shows that this fails if a field from the fragment is also selected
in the top level selection. This is a valid use-case when a component lower
in the tree requires the data and the component making the query does too.